Bug 197415

Summary:

[WPE][Qt] Use C++17 instead of C++14

Product:

WebKit

Reporter:

Ludovico de Nittis <ludovico.denittis>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, pnormand, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Ludovico de Nittis

Reported 2019-04-30 08:03:10 PDT

This is a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131 The WPE Qt port was not updated to C++17 and this leaded to a compilation error. In file included from DerivedSources/ForwardingHeaders/wtf/HashTraits.h:28, from DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:28, from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h:31, from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.cpp:24: DerivedSources/ForwardingHeaders/wtf/Optional.h:322:68: error: expected ‘)’ before ‘,’ token template <class... Args> explicit Optional_base(std::in_place_t, Args&&... args) ~ ^ ) [...] Full log here https://paste.ubuntu.com/p/nvWmBjpq65/ I'm going to upload a patch for this.

Attachments
Patch (2.80 KB, patch) 2019-04-30 08:08 PDT, Ludovico de Nittis	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ludovico de Nittis

Comment 1 2019-04-30 08:08:39 PDT

Created attachment 368563 [details] Patch

WebKit Commit Bot

Comment 2 2019-05-20 07:51:00 PDT

Comment on attachment 368563 [details] Patch Clearing flags on attachment: 368563 Committed r245516: <https://trac.webkit.org/changeset/245516>

WebKit Commit Bot

Comment 3 2019-05-20 07:51:01 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 4 2019-05-20 07:51:18 PDT

<rdar://problem/50945871>

Note You need to log in before you can comment on or make changes to this bug.