Bug 197415

Summary:

[WPE][Qt] Use C++17 instead of C++14

Product:

WebKit

Reporter:

Ludovico de Nittis <ludovico.denittis>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, pnormand, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ludovico de Nittis 2019-04-30 08:03:10 PDT

This is a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131

The WPE Qt port was not updated to C++17 and this leaded to a compilation error.

In file included from DerivedSources/ForwardingHeaders/wtf/HashTraits.h:28,
                 from DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:28,
                 from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h:31,
                 from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.cpp:24:
DerivedSources/ForwardingHeaders/wtf/Optional.h:322:68: error: expected ‘)’ before ‘,’ token
     template <class... Args> explicit Optional_base(std::in_place_t, Args&&... args)
                                                    ~                                                               ^
                                                                                                                    )
[...]

Full log here https://paste.ubuntu.com/p/nvWmBjpq65/

I'm going to upload a patch for this.

Comment 1 Ludovico de Nittis 2019-04-30 08:08:39 PDT

Created attachment 368563 [details]
Patch

Comment 2 WebKit Commit Bot 2019-05-20 07:51:00 PDT

Comment on attachment 368563 [details]
Patch

Clearing flags on attachment: 368563

Committed r245516: <https://trac.webkit.org/changeset/245516>

Comment 3 WebKit Commit Bot 2019-05-20 07:51:01 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-05-20 07:51:18 PDT

<rdar://problem/50945871>