| Summary: | WebCore::StyleColorScheme should not have explicitly-declared copy constructor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
| Component: | WebCore Misc. | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 368555 [details]
Patch
Comment on attachment 368555 [details]
Patch
r=me assuming bots are happy
Comment on attachment 368555 [details] Patch Clearing flags on attachment: 368555 Committed r244768: <https://trac.webkit.org/changeset/244768> All reviewed patches have been landed. Closing bug. |
Since we enabled dark mode CSS for GTK, I can't see any real warnings past this warning spam: [1135/1984] Building CXX object Source/WebCore/CMakeFiles...s/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp.o In file included from ../../Source/WebCore/rendering/RenderObject.h:35, from ../../Source/WebCore/rendering/RenderElement.h:26, from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25, from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28, from ../../Source/WebCore/rendering/RenderBox.h:26, from ../../Source/WebCore/rendering/RenderLayer.h:51, from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1: ../../Source/WebCore/rendering/style/RenderStyle.h: In member function ‘void WebCore::RenderStyle::setColorScheme(WebCore::StyleColorScheme)’: ../../Source/WebCore/rendering/style/RenderStyle.h:1182:97: warning: implicitly-declared ‘constexpr WebCore::StyleColorScheme& WebCore::StyleColorScheme::operator=(const WebCore::StyleColorScheme&)’ is deprecated [-Wdeprecated-copy] 1182 | void setColorScheme(StyleColorScheme supported) { SET_VAR(m_rareInheritedData, colorScheme, supported); } | ^~~~~~~~~ ../../Source/WebCore/rendering/style/RenderStyle.h:94:39: note: in definition of macro ‘SET_VAR’ 94 | group.access().variable = value; \ | ^~~~~ In file included from ../../Source/WebCore/rendering/style/StyleRareInheritedData.h:41, from ../../Source/WebCore/rendering/style/RenderStyle.h:59, from ../../Source/WebCore/rendering/RenderObject.h:35, from ../../Source/WebCore/rendering/RenderElement.h:26, from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25, from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28, from ../../Source/WebCore/rendering/RenderBox.h:26, from ../../Source/WebCore/rendering/RenderLayer.h:51, from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1: ../../Source/WebCore/rendering/style/StyleColorScheme.h:39:5: note: because ‘WebCore::StyleColorScheme’ has user-provided ‘WebCore::StyleColorScheme::StyleColorScheme(const WebCore::StyleColorScheme&)’ 39 | StyleColorScheme(const StyleColorScheme& other) | ^~~~~~~~~~~~~~~~ The copy constructor should be removed.