Bug 197391

Summary:

AudioContext methods on a stopped AudioContext should exit early

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, jer.noble, sroberts, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

197431

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews204 for win-future	none
Patch	none
Archive of layout-test-results from ews202 for win-future	none
Relanding	none

youenn fablet

Reported 2019-04-29 15:18:13 PDT

Reject/throw when calling AudioContext methods on a stopped AudioContext

Attachments
Patch (20.86 KB, patch) 2019-04-29 15:27 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.95 MB, application/zip) 2019-04-29 17:22 PDT, EWS Watchlist	no flags	Details
Patch (21.62 KB, patch) 2019-04-29 17:25 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.96 MB, application/zip) 2019-04-29 20:12 PDT, EWS Watchlist	no flags	Details
Relanding (21.60 KB, patch) 2019-04-30 15:34 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2019-04-29 15:27:04 PDT

Created attachment 368501 [details] Patch

Radar WebKit Bug Importer

Comment 2 2019-04-29 15:27:30 PDT

<rdar://problem/50314026>

youenn fablet

Comment 3 2019-04-29 15:28:05 PDT

Note that Chrome, Firefox and WebKit are all other the place here.

EWS Watchlist

Comment 4 2019-04-29 17:21:54 PDT

Comment on attachment 368501 [details] Patch Attachment 368501 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12035017 New failing tests: http/wpt/webaudio/audiocontext-stopped.html

EWS Watchlist

Comment 5 2019-04-29 17:22:05 PDT

Created attachment 368520 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

youenn fablet

Comment 6 2019-04-29 17:25:37 PDT

Created attachment 368521 [details] Patch

EWS Watchlist

Comment 7 2019-04-29 20:12:01 PDT

Comment on attachment 368521 [details] Patch Attachment 368521 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12036674 New failing tests: js/dom/custom-constructors.html

EWS Watchlist

Comment 8 2019-04-29 20:12:13 PDT

Created attachment 368534 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Eric Carlson

Comment 9 2019-04-30 06:58:19 PDT

Comment on attachment 368521 [details] Patch r=me once the bots are happy

youenn fablet

Comment 10 2019-04-30 07:58:48 PDT

Comment on attachment 368521 [details] Patch Win error is unrelated, the corresponding test is not using WebAudio at all

WebKit Commit Bot

Comment 11 2019-04-30 08:17:13 PDT

Comment on attachment 368521 [details] Patch Clearing flags on attachment: 368521 Committed r244774: <https://trac.webkit.org/changeset/244774>

WebKit Commit Bot

Comment 12 2019-04-30 08:17:14 PDT

All reviewed patches have been landed. Closing bug.

Shawn Roberts

Comment 13 2019-04-30 12:38:46 PDT

It appears that after changes in https://trac.webkit.org/changeset/244774 is causing several assertion failures on Debug testers https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r244775%20(3505)/results.html https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r244776%20(7619)/results.html Crash Log: ASSERTION FAILED: !m_audioProducers.hasNullReferences() ./dom/Document.cpp(3929) : void WebCore::Document::updateIsPlayingMedia(uint64_t) 1 0x61d14be89 WTFCrash 2 0x621b8f59b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x623ef330d WebCore::Document::updateIsPlayingMedia(unsigned long long) 4 0x623ef351e WebCore::Document::removeAudioProducer(WebCore::MediaProducer&) 5 0x623629063 WebCore::MediaStreamTrack::~MediaStreamTrack() 6 0x6236291e5 WebCore::MediaStreamTrack::~MediaStreamTrack() 7 0x623629289 WebCore::MediaStreamTrack::~MediaStreamTrack() https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r244775%20(3505)/imported/w3c/web-platform-tests/webrtc/RTCIceTransport-extension.https-crash-log.txt

WebKit Commit Bot

Comment 14 2019-04-30 13:05:59 PDT

Re-opened since this is blocked by bug 197431

Shawn Roberts

Comment 15 2019-04-30 13:17:29 PDT

I looked at the wrong commit for the Assertion failure. It was actually the one before this also by you. r244773 Bots did not have results between r244773-r244775

youenn fablet

Comment 16 2019-04-30 15:34:59 PDT

Created attachment 368621 [details] Relanding

WebKit Commit Bot

Comment 17 2019-05-01 10:09:26 PDT

Comment on attachment 368621 [details] Relanding Clearing flags on attachment: 368621 Committed r244825: <https://trac.webkit.org/changeset/244825>

WebKit Commit Bot

Comment 18 2019-05-01 10:09:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.