| Summary: | AudioContext methods on a stopped AudioContext should exit early | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, jer.noble, sroberts, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 197431 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2019-04-29 15:18:13 PDT
Created attachment 368501 [details]
Patch
Note that Chrome, Firefox and WebKit are all other the place here. Comment on attachment 368501 [details] Patch Attachment 368501 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12035017 New failing tests: http/wpt/webaudio/audiocontext-stopped.html Created attachment 368520 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 368521 [details]
Patch
Comment on attachment 368521 [details] Patch Attachment 368521 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12036674 New failing tests: js/dom/custom-constructors.html Created attachment 368534 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 368521 [details]
Patch
r=me once the bots are happy
Comment on attachment 368521 [details]
Patch
Win error is unrelated, the corresponding test is not using WebAudio at all
Comment on attachment 368521 [details] Patch Clearing flags on attachment: 368521 Committed r244774: <https://trac.webkit.org/changeset/244774> All reviewed patches have been landed. Closing bug. It appears that after changes in https://trac.webkit.org/changeset/244774 is causing several assertion failures on Debug testers https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r244775%20(3505)/results.html https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r244776%20(7619)/results.html Crash Log: ASSERTION FAILED: !m_audioProducers.hasNullReferences() ./dom/Document.cpp(3929) : void WebCore::Document::updateIsPlayingMedia(uint64_t) 1 0x61d14be89 WTFCrash 2 0x621b8f59b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x623ef330d WebCore::Document::updateIsPlayingMedia(unsigned long long) 4 0x623ef351e WebCore::Document::removeAudioProducer(WebCore::MediaProducer&) 5 0x623629063 WebCore::MediaStreamTrack::~MediaStreamTrack() 6 0x6236291e5 WebCore::MediaStreamTrack::~MediaStreamTrack() 7 0x623629289 WebCore::MediaStreamTrack::~MediaStreamTrack() https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r244775%20(3505)/imported/w3c/web-platform-tests/webrtc/RTCIceTransport-extension.https-crash-log.txt Re-opened since this is blocked by bug 197431 I looked at the wrong commit for the Assertion failure. It was actually the one before this also by you. r244773 Bots did not have results between r244773-r244775 Created attachment 368621 [details]
Relanding
Comment on attachment 368621 [details] Relanding Clearing flags on attachment: 368621 Committed r244825: <https://trac.webkit.org/changeset/244825> All reviewed patches have been landed. Closing bug. |