Bug 197373

Summary:

Bug to test new EWS functionality

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, glenn, guijemont

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Proposed patch	none
Proposed patch	none

Aakash Jain

Reported 2019-04-29 10:15:06 PDT

Fix few flaky API tests.

Attachments
Proposed patch (19.33 KB, patch) 2019-04-29 10:17 PDT, Aakash Jain	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (1008.79 KB, application/zip) 2019-04-29 11:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (878.29 KB, application/zip) 2019-04-29 11:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (2.27 MB, application/zip) 2019-04-29 11:29 PDT, EWS Watchlist	no flags	Details
Proposed patch (1.21 KB, patch) 2019-04-29 13:04 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (1.11 KB, patch) 2019-04-30 13:22 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-29 10:17:05 PDT

Created attachment 368464 [details] Proposed patch

EWS Watchlist

Comment 2 2019-04-29 10:20:09 PDT Comment hidden (obsolete)

Attachment 368464 [details] did not pass style-queue: ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2019-04-29 11:26:09 PDT Comment hidden (obsolete)

Comment on attachment 368464 [details] Proposed patch Attachment 368464 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12031072 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-04-29 11:26:10 PDT Comment hidden (obsolete)

Created attachment 368468 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-04-29 11:26:14 PDT Comment hidden (obsolete)

Comment on attachment 368464 [details] Proposed patch Attachment 368464 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12031068 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2019-04-29 11:26:16 PDT Comment hidden (obsolete)

Created attachment 368469 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-04-29 11:29:53 PDT Comment hidden (obsolete)

Comment on attachment 368464 [details] Proposed patch Attachment 368464 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12031042 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2019-04-29 11:29:56 PDT Comment hidden (obsolete)

Created attachment 368471 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Aakash Jain

Comment 9 2019-04-29 13:00:34 PDT

Note that this bug is just for testing EWS.

Aakash Jain

Comment 10 2019-04-29 13:04:07 PDT

Created attachment 368477 [details] Proposed patch

Guillaume Emont

Comment 11 2019-04-30 05:26:27 PDT

It looks like attachment https://bugs.webkit.org/attachment.cgi?id=368464 is stalling jsc-armv7 ews. It's been running for over 18hours and stalling the queue, I'm gonna kill the process to let the EWS get to other patches.

Aakash Jain

Comment 12 2019-04-30 13:22:12 PDT

Created attachment 368601 [details] Proposed patch

Note You need to log in before you can comment on or make changes to this bug.