| Summary: | [WebGPU] Move 'gpu' API entry point from DOMWindow to Navigator | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, mmaxfield, rniwa, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Justin Fan
2019-04-27 17:19:39 PDT
Created attachment 368417 [details]
Patch
Created attachment 368418 [details]
Patch
Comment on attachment 368418 [details] Patch Attachment 368418 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12019461 New failing tests: fast/dom/navigator-detached-no-crash.html Created attachment 368419 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 368482 [details]
Patch
Created attachment 368484 [details]
Patch
Created attachment 368492 [details]
Patch
Comment on attachment 368492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368492&action=review > Source/WebCore/ChangeLog:6 > + Latest API provides 'gpu' through Navigator instead of DOMWindow. Replace DOMWindowWebGPU with NavigatorGPU. Is this meant to be exposed to workers in any way? > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). This should be *before* the changelog description. > Source/WebCore/Modules/webgpu/NavigatorGPU.idl:32 > + [SameObject] readonly attribute WebGPU gpu; Note that [SameObject] is currently a no-op AFAIK and you'll need to write custom bindings code (i.e. visitor) to ensure that the same object is always returned. (In reply to Chris Dumez from comment #8) > Comment on attachment 368492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368492&action=review > > > Source/WebCore/ChangeLog:6 > > + Latest API provides 'gpu' through Navigator instead of DOMWindow. Replace DOMWindowWebGPU with NavigatorGPU. > > Is this meant to be exposed to workers in any way? > > > Source/WebCore/ChangeLog:8 > > + Reviewed by NOBODY (OOPS!). > > This should be *before* the changelog description. > > > Source/WebCore/Modules/webgpu/NavigatorGPU.idl:32 > > + [SameObject] readonly attribute WebGPU gpu; > > Note that [SameObject] is currently a no-op AFAIK and you'll need to write > custom bindings code (i.e. visitor) to ensure that the same object is always > returned. Thanks for looking. Yes, there's also a partial interface for WorkerNavigator; I'll update. Comment on attachment 368492 [details] Patch Attachment 368492 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12033795 New failing tests: fast/dom/navigator-detached-no-crash.html Created attachment 368503 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 368528 [details]
Patch
Comment on attachment 368528 [details] Patch Clearing flags on attachment: 368528 Committed r244777: <https://trac.webkit.org/changeset/244777> All reviewed patches have been landed. Closing bug. |