Bug 197347 – [iOS]Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)

• Component: UI Events
• Status: RESOLVED FIXED

[alan]

<rdar://problem/49393423>

[alan]

Created attachment 368416 [details]
Patch

[EWS Watchlist]

Comment on attachment 368416 [details]
Patch

Attachment 368416 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12019552

New failing tests:
http/tests/paymentrequest/payment-response-payerName-attribute.https.html
http/tests/paymentrequest/payment-request-abort-method.https.html
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
http/tests/adClickAttribution/anchor-tag-attributes-validation.html
http/tests/paymentrequest/updateWith-method-pmi-handling.https.html
http/tests/paymentrequest/payment-response-complete-method.https.html
http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
http/tests/paymentrequest/payment-response-retry-method.https.html
http/tests/paymentrequest/rejects_if_not_active.https.html
http/tests/paymentrequest/payment-request-merchant-validation.https.html
http/tests/paymentrequest/payment-request-show-method.https.html
http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html

[EWS Watchlist]

Created attachment 368423 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

[EWS Watchlist]

Comment on attachment 368416 [details]
Patch

Attachment 368416 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12020636

New failing tests:
http/tests/paymentrequest/payment-response-payerName-attribute.https.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
http/tests/paymentrequest/payment-request-show-method.https.html
http/tests/paymentrequest/rejects_if_not_active.https.html
http/tests/adClickAttribution/anchor-tag-attributes-validation.html
http/tests/paymentrequest/updateWith-method-pmi-handling.https.html
http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html
http/tests/paymentrequest/payment-response-complete-method.https.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
fast/files/file-reader-abort-using-open-panel.html
http/tests/paymentrequest/payment-response-retry-method.https.html
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
http/tests/paymentrequest/payment-request-merchant-validation.https.html
http/tests/paymentrequest/payment-request-abort-method.https.html
http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html

[EWS Watchlist]

Created attachment 368424 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

[alan]

I can repro these failures locally even with my change stashed.

[alan]

Created attachment 368475 [details]
Patch

[Wenson Hsieh]

Comment on attachment 368475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368475&action=review

> Source/WebCore/page/ios/FrameIOS.mm:427
> +        auto node = hitTestResult.innerNode();

Nit - auto*?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:734
> +    auto shiftKey = modifiers.contains(WebEvent::Modifier::ShiftKey);

Nit - I *think* we prefer bool over auto in cases like this 🤷🏻‍♂️

> LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html:51
> +    	    setTimeout("testRunner.notifyDone()", 0);

Nit - it looks like there's a tab character somewhere here.

> LayoutTests/fast/events/touch/ios/double-tap-for-double-click3.html:50
> +    	setTimeout("testRunner.notifyDone()", 0);

Nit - another tab.

[alan]

Created attachment 368488 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 368488 [details]
Patch

Clearing flags on attachment: 368488

Committed r244755: <https://trac.webkit.org/changeset/244755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Reverted r244755 for reason:

Casued several test failures on iOS

Committed r244762: <https://trac.webkit.org/changeset/244762>

[alan]

Created attachment 368536 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 368536 [details]
Patch

Clearing flags on attachment: 368536

Committed r244775: <https://trac.webkit.org/changeset/244775>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.