Bug 197339

Summary: run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, ews-watchlist, glenn, lforschler, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch dewei_zhu: review+

Stephanie Lewis
Reported 2019-04-26 19:00:02 PDT
Some tasks (like reboots) take a significant amount of time so we should have the ability to run them once and not have to run them in between every iteration.
Attachments
patch (9.07 KB, patch)
2019-04-26 19:13 PDT, Stephanie Lewis 		dewei_zhu: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephanie Lewis
Comment 1 2019-04-26 19:13:40 PDT
Created attachment 368380 [details] patch
EWS Watchlist
Comment 2 2019-04-26 19:15:45 PDT
Attachment 368380 [details] did not pass style-queue: ERROR: Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
dewei_zhu
Comment 3 2019-04-26 19:24:39 PDT
Comment on attachment 368380 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=368380&action=review > Tools/ChangeLog:8 > + Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire Four more spaces?
Stephanie Lewis
Comment 4 2019-04-30 16:53:12 PDT
Landed https://trac.webkit.org/changeset/244730/webkit
Radar WebKit Bug Importer
Comment 5 2019-04-30 16:54:18 PDT
<rdar://problem/50355843>
Note You need to log in before you can comment on or make changes to this bug.