Summary: | [WKTR] Move test timeout handling to the UIProcess | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, ap, beidson, commit-queue, darin, ggaren, jbedard, lforschler, rniwa, ryanhaddad, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2019-04-26 16:48:57 PDT
Created attachment 368366 [details]
Patch
Created attachment 368367 [details]
Patch
Comment on attachment 368367 [details] Patch Clearing flags on attachment: 368367 Committed r244723: <https://trac.webkit.org/changeset/244723> All reviewed patches have been landed. Closing bug. I think with PSON changes, something like this makes sense. It's probably a performance win for layout tests, but I don't have the numbers to back up that claim. Although, I must question what made you think to do this, because I would have expected that the timeouts a level up (in run-webkit-tests) would have caught most of these cases. (In reply to Jonathan Bedard from comment #6) > I think with PSON changes, something like this makes sense. It's probably a > performance win for layout tests, but I don't have the numbers to back up > that claim. > > Although, I must question what made you think to do this, because I would > have expected that the timeouts a level up (in run-webkit-tests) would have > caught most of these cases. The crashes above when I run the layout tests locally is what pushed to me fix this. |