| Summary: | Web Inspector: DOM: dragging a node to the console should log the node | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2019-04-26 15:50:19 PDT
Created attachment 368414 [details]
Patch
For some reason, the drop doesn't work on anything that isn't normally editable :(
Comment on attachment 368414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368414&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:636 > + let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node"); "Selected Node/Element" => "Dropped Node/Element"? > Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:189 > + let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node"); Ditto. Created attachment 369035 [details]
Patch
Comment on attachment 369035 [details] Patch Clearing flags on attachment: 369035 Committed r244946: <https://trac.webkit.org/changeset/244946> All reviewed patches have been landed. Closing bug. |