Bug 197308

Summary: [Cairo] Improve ShadowBlur performance using tiling optimization
Product: WebKit Reporter: Tomoki Imai <tomoki.imai>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, don.olmstead, ews-watchlist, mcatanzaro, pnormand, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
Attachments:
Description Flags
Patch
none
Patch
none
Outer shadow benchmark
none
Inner shadow benchmark
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Tomoki Imai
Reported 2019-04-25 23:20:23 PDT
We want to enable tiling tiling-based optimization for drawRectShadow() and drawInsetShadow(). Since r228776, cairo ports doesn't have tiling-based optimization, we see some performance regressions.
Attachments
Patch (51.21 KB, patch)
2019-04-25 23:24 PDT, Tomoki Imai 		no flags
DetailsFormatted DiffDiff
Patch (51.20 KB, patch)
2019-04-26 00:20 PDT, Tomoki Imai 		no flags
DetailsFormatted DiffDiff
Outer shadow benchmark (642 bytes, text/html)
2019-04-26 00:32 PDT, Tomoki Imai 		no flags
Details
Inner shadow benchmark (647 bytes, text/html)
2019-04-26 00:33 PDT, Tomoki Imai 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.70 MB, application/zip)
2019-04-26 02:18 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tomoki Imai
Comment 1 2019-04-25 23:24:15 PDT
Created attachment 368306 [details] Patch Patch
Tomoki Imai
Comment 2 2019-04-26 00:20:36 PDT
Created attachment 368307 [details] Patch Try to Fix Mac build
Tomoki Imai
Comment 3 2019-04-26 00:32:29 PDT
Created attachment 368308 [details] Outer shadow benchmark Simple outer shadowblur benchmark
Tomoki Imai
Comment 4 2019-04-26 00:33:10 PDT
Created attachment 368309 [details] Inner shadow benchmark Inset shadow benchmark
Tomoki Imai
Comment 5 2019-04-26 00:38:27 PDT
I ran LayoutTests for WinCairo and GTK, and didn't see any regression cases.
EWS Watchlist
Comment 6 2019-04-26 02:18:31 PDT
Comment on attachment 368307 [details] Patch Attachment 368307 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12003413 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-abort.https.html
EWS Watchlist
Comment 7 2019-04-26 02:18:32 PDT
Created attachment 368312 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 8 2019-05-03 11:31:11 PDT
Comment on attachment 368307 [details] Patch Clearing flags on attachment: 368307 Committed r244913: <https://trac.webkit.org/changeset/244913>
WebKit Commit Bot
Comment 9 2019-05-03 11:31:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-05-03 11:32:45 PDT
<rdar://problem/50450914>
Note You need to log in before you can comment on or make changes to this bug.