Bug 197307

Summary:

check-webkit-style complains the first block in while loop.

Product:

WebKit

Reporter:

Takashi Komori <takashi.komori>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Basuke.Suzuki, commit-queue, ews-watchlist, glenn, Hironori.Fujii, lforschler, webkit-bug-importer, yoshiaki.jitsukawa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191650

Attachments:

Description	Flags
sample	none
Patch	none
Patch	none

Description Takashi Komori 2019-04-25 23:19:45 PDT

Created attachment 368304 [details]
sample

Code below is reported as an style error.
>ERROR: wrongly-style-checked-block.cpp:18:  This { should be at the end of the previous line  [whitespace/braces] [4]

void funcB()
{
    while (true) {
        {
            int y;
        }
    }
}

But the code below is not.

void funcA()
{
    while (true) {
        int x;
        {
            int y;
        }
    }
}

Comment 1 Yoshiaki Jitsukawa 2019-04-26 06:11:14 PDT

Created attachment 368315 [details]
Patch

Comment 2 Yoshiaki Jitsukawa 2019-04-26 06:21:59 PDT

Created attachment 368316 [details]
Patch

Comment 3 WebKit Commit Bot 2019-04-26 09:25:32 PDT

Comment on attachment 368316 [details]
Patch

Clearing flags on attachment: 368316

Committed r244688: <https://trac.webkit.org/changeset/244688>

Comment 4 WebKit Commit Bot 2019-04-26 09:25:34 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-04-26 09:26:48 PDT

<rdar://problem/50245052>