Bug 197307

Summary:

check-webkit-style complains the first block in while loop.

Product:

WebKit

Reporter:

Takashi Komori <takashi.komori>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, basuke, commit-queue, ews-watchlist, fujii.hironori, glenn, lforschler, webkit-bug-importer, yoshiaki.jitsukawa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191650

Attachments:

Description	Flags
sample	none
Patch	none
Patch	none

Takashi Komori

Reported 2019-04-25 23:19:45 PDT

Created attachment 368304 [details] sample Code below is reported as an style error. >ERROR: wrongly-style-checked-block.cpp:18: This { should be at the end of the previous line [whitespace/braces] [4] void funcB() { while (true) { { int y; } } } But the code below is not. void funcA() { while (true) { int x; { int y; } } }

Attachments
sample (244 bytes, text/plain) 2019-04-25 23:19 PDT, Takashi Komori	no flags	Details
Patch (3.83 KB, patch) 2019-04-26 06:11 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (3.83 KB, patch) 2019-04-26 06:21 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yoshiaki Jitsukawa

Comment 1 2019-04-26 06:11:14 PDT

Created attachment 368315 [details] Patch

Yoshiaki Jitsukawa

Comment 2 2019-04-26 06:21:59 PDT

Created attachment 368316 [details] Patch

WebKit Commit Bot

Comment 3 2019-04-26 09:25:32 PDT

Comment on attachment 368316 [details] Patch Clearing flags on attachment: 368316 Committed r244688: <https://trac.webkit.org/changeset/244688>

WebKit Commit Bot

Comment 4 2019-04-26 09:25:34 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-04-26 09:26:48 PDT

<rdar://problem/50245052>

Note You need to log in before you can comment on or make changes to this bug.