Bug 197288

Summary:	[AppleWin] Upgrade bots to Visual Studio 2019
Product:	WebKit	Reporter:	Don Olmstead <don.olmstead>
Component:	Tools / Tests	Assignee:	Brent Fulgham <bfulgham>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	achristensen, ap, bfulgham, Hironori.Fujii, lforschler, lingho, pvollan, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	204000
Bug Blocks:

Description Don Olmstead 2019-04-25 11:27:41 PDT

Visual Studio 2019 was released this month, https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes . WinCairo currently requires either an old version of 2017 or 2019 to build. Currently our bots are using 2019 with ninja but we'd like to switch general development to 2019. AppleWin should bump the version as well.

I would suggest installing Visual Studio 2019 Build Tools on the bots, direct link is https://aka.ms/vs/16/release/vs_buildtools.exe or expand the Tools section at https://visualstudio.microsoft.com/downloads/ , which has just the build tools and not the IDE. Its meant more for bots.

Our bots have the following workloads installed see https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2019 for a list of all workloads

    Microsoft.VisualStudio.Component.Roslyn.Compiler
    Microsoft.Component.MSBuild
    Microsoft.VisualStudio.Component.CoreBuildTools
    Microsoft.VisualStudio.Workload.MSBuildTools
    Microsoft.VisualStudio.Component.Windows10SDK
    Microsoft.VisualStudio.Component.VC.CoreBuildTools
    Microsoft.VisualStudio.Component.VC.Tools.x86.x64
    Microsoft.VisualStudio.Component.VC.Redist.14.Latest
    Microsoft.VisualStudio.Component.Windows10SDK.17763
    Microsoft.VisualStudio.Workload.VCTools

At the same time if you're intending to use MSBuild through build-webkit you'll need to update CMake to a 3.14.x version which has support for 2019. Currently 3.14.3 is the latest.

Comment 1 Don Olmstead 2019-04-25 14:22:33 PDT

Alex I think this will make the bots green again.

Comment 2 Alex Christensen 2019-04-25 14:23:39 PDT

I think we need to try to keep 2017 for another little while.

Comment 3 Don Olmstead 2019-04-25 14:28:40 PDT

(In reply to Alex Christensen from comment #2)
> I think we need to try to keep 2017 for another little while.

You may have to roll out that C++17 patch then. If you're not able to reproduce the build breakage in the bots locally and you're using 2017 my bet is that the bots need to be updated to a newer version of 2017. MS is testing AppleWin and WinCairo internally to check for compiler breakages.

2019 is probably a good idea for you all in the long term. WinCairo flat out doesn't work without it.

Comment 4 Alex Christensen 2019-04-25 22:13:41 PDT

We successfully covered up all the bugs for now, but we should still push to upgrade.

Comment 5 Don Olmstead 2019-06-24 15:09:40 PDT

Here's the command line we use for installing on WinCairo. Adding Brent since he was asking for information on the Windows SDK.

C:\Users\ContainerAdministrator\AppData\Local\Temp\VSBuildTools2019.exe --quiet --norestart --nocache --wait --add Microsoft.VisualStudio.Component.Roslyn.Compiler --add Microsoft.Component.MSBuild --add Microsoft.VisualStudio.Component.CoreBuildTools --add Microsoft.VisualStudio.Workload.MSBuildTools --add Microsoft.VisualStudio.Component.Windows10SDK --add Microsoft.VisualStudio.Component.VC.CoreBuildTools --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --add Microsoft.VisualStudio.Component.VC.Redist.14.Latest --add Microsoft.VisualStudio.Component.Windows10SDK.17763 --add Microsoft.VisualStudio.Workload.VCTools --installPath C:\MSVS

Again we use Visual Studio 2019 Build Tools which is meant for build servers. You won't get an IDE but you'll get all the things to build with.

Comment 6 Don Olmstead 2019-08-19 10:05:44 PDT

Any updates on this?

Comment 7 Brent Fulgham 2019-08-20 11:20:10 PDT

Pulling into radar to track updates on bots and EWS.

Comment 8 Radar WebKit Bug Importer 2019-08-20 11:20:26 PDT

<rdar://problem/54520227>

Comment 9 Fujii Hironori 2019-11-14 18:21:02 PST

Some bots seem to start using Visual Studio 2019. Will it be available soon?

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/8331

> -- Building for: Visual Studio 16 2019
> -- The C compiler identification is MSVC 19.23.28107.0
> -- The CXX compiler identification is MSVC 19.23.28107.0

Comment 10 Alexey Proskuryakov 2019-11-14 20:56:33 PST

The upgrade is supposed to be all done.

Comment 11 Fujii Hironori 2019-11-14 21:08:40 PST

Win7 bot still seems using VS2017?
> Using Visual Studio: /cygdrive/c/Program Files (x86)/Microsoft Visual Studio/2017/Community
https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Build%29/builds/8567/steps/compile-webkit/logs/stdio

Comment 12 Alexey Proskuryakov 2019-11-15 11:07:28 PST

I thought that Win7 was no longer supported. But of course we need to remove the bots if that's the case. Brent and Per Arne, what do you say?