Web Inspector: user gesture toggle should also force user interaction flag

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

This would allow `$0.click()` to show a keyboard for editable elements on iOS devices.

[Devin Rousso]

Created attachment 368209 [details]
Patch

[EWS Watchlist]

Attachment 368209 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:506:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:507:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 368209 [details]
Patch

Attachment 368209 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11992081

New failing tests:
inspector/runtime/evaluate-userGestureEmulation.html

[EWS Watchlist]

Created attachment 368214 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 368209 [details]
Patch

Attachment 368209 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11992126

New failing tests:
inspector/runtime/evaluate-userGestureEmulation.html

[EWS Watchlist]

Created attachment 368216 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Devin Rousso]

Created attachment 368362 [details]
Patch

[EWS Watchlist]

Attachment 368362 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:506:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:507:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 368362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368362&action=review

> Source/WebCore/page/ChromeClient.h:507
> +    virtual void setUserIsInteracting(bool /* userIsInteracting */) { }

The comment doesn't seem useful over just a `(bool)`.

> LayoutTests/inspector/runtime/evaluate-userGestureEmulation-userIsInteracting-expected.txt:6
> +-- Running test case: EvaluateWithoutEmulatingUserGesture.userIsInteracting
> +User is interacting

Seems this line should be `User is not Interacting`. That is what this change is trying to address, right?

> LayoutTests/inspector/runtime/evaluate-userGestureEmulation-userIsInteracting.html:12
> +        TestPage.addResult(window.internals.userIsInteracting() ? "User is interacting" : "User is not Interacting");

Nit: Keep the case the same. Maybe:

    User is Interacting
    User is NOT Interacting

[Joseph Pecoraro]

Comment on attachment 368362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368362&action=review

> Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:172
> +    bool userWasInteracting = pageChromeClient.userIsInteracting();
> +    if (!userWasInteracting)

Seems this condition should probably be:

    if (!userWasInteracting && emulateUserGesture)

Otherwise it will always setting interaction even if `emulateUserGesture` was not true.

[Devin Rousso]

Created attachment 369037 [details]
Patch

[EWS Watchlist]

Attachment 369037 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:506:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:507:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 369037 [details]
Patch

Attachment 369037 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12095765

New failing tests:
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369046 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Joseph Pecoraro]

Comment on attachment 369037 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 369037 [details]
Patch

Clearing flags on attachment: 369037

Committed r245366: <https://trac.webkit.org/changeset/245366>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50830155>