Bug 197235

Summary:

AX: Build failure in WKFullKeyboardAccessWatcher.mm

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Description chris fleizach 2019-04-24 09:32:33 PDT

WKFullKeyboardAccessWatcher.mm:55:33: error: use of undeclared identifier '_AXSFullKeyboardAccessEnabled'; did you mean 'WebKit::ServiceWorkerProcessProxy::fullKeyboardAccessEnabled'?

Comment 1 Radar WebKit Bug Importer 2019-04-24 09:32:48 PDT

<rdar://problem/50170205>

Comment 2 chris fleizach 2019-04-24 09:35:28 PDT

Created attachment 368131 [details]
patch

Comment 3 WebKit Commit Bot 2019-04-24 10:26:20 PDT

Comment on attachment 368131 [details]
patch

Rejecting attachment 368131 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 368131, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=368131&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=197235&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 368131 from bug 197235.
Fetching: https://bugs.webkit.org/attachment.cgi?id=368131
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm
Hunk #1 FAILED at 28.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm
Hunk #1 FAILED at 28.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   b2e96ad65ba..2d8ce3cf1f9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 244593 = b2e96ad65ba9a0cb9c820d25ce5db807036b737d
r244594 = 7bdeec136717857a3b650836ff1d461015f3f0f7
r244595 = 629ca74f74ea0fec79c914acdd2982a2a786f715
r244596 = 2d8ce3cf1f916a1752be87bfd008df23dd4174f2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/11984531

Comment 4 Ryan Haddad 2019-04-24 10:32:21 PDT

David fixed this in https://trac.webkit.org/changeset/244596/webkit