Summary: | Remove Ad Click Attribution data when removing website data | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||
Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
John Wilander
2019-04-23 15:20:56 PDT
Created attachment 368076 [details]
Patch
Comment on attachment 368076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368076&action=review > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:181 > + m_unconvertedAdClickAttributionMap.removeIf([domain = domain](auto& keyAndValue) { domain = domain should be &domain > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:182 > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) could be written on one line: return keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain; > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:187 > + m_convertedAdClickAttributionMap.removeIf([domain = WTFMove(domain)](auto& keyAndValue) { ditto, should be &domain. > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:188 > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) ditto, could be written on 1 line. (In reply to Chris Dumez from comment #3) > Comment on attachment 368076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368076&action=review > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:181 > > + m_unconvertedAdClickAttributionMap.removeIf([domain = domain](auto& keyAndValue) { > > domain = domain > should be > &domain > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:182 > > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) > > could be written on one line: > return keyAndValue.key.first.registrableDomain == domain || > keyAndValue.key.second.registrableDomain == domain; > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:187 > > + m_convertedAdClickAttributionMap.removeIf([domain = WTFMove(domain)](auto& keyAndValue) { > > ditto, should be &domain. > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:188 > > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) > > ditto, could be written on 1 line. Thank you, I will fix all these things. Created attachment 368086 [details]
Patch for landing
Comment on attachment 368086 [details] Patch for landing Clearing flags on attachment: 368086 Committed r244572: <https://trac.webkit.org/changeset/244572> All reviewed patches have been landed. Closing bug. |