Bug 197215

Summary:

Remove Ad Click Attribution data when removing website data

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

John Wilander

Reported 2019-04-23 15:20:56 PDT

Calls to WebsiteDataStore::removeData() should remove Ad Click Attribution data.

Attachments
Patch (28.79 KB, patch) 2019-04-23 16:02 PDT, John Wilander	no flags	Details Formatted Diff Diff
Patch for landing (28.68 KB, patch) 2019-04-23 16:55 PDT, John Wilander	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

John Wilander

Comment 1 2019-04-23 15:21:18 PDT

<rdar://problem/47668988>

John Wilander

Comment 2 2019-04-23 16:02:23 PDT

Created attachment 368076 [details] Patch

Chris Dumez

Comment 3 2019-04-23 16:08:56 PDT

Comment on attachment 368076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368076&action=review > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:181 > + m_unconvertedAdClickAttributionMap.removeIf([domain = domain](auto& keyAndValue) { domain = domain should be &domain > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:182 > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) could be written on one line: return keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain; > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:187 > + m_convertedAdClickAttributionMap.removeIf([domain = WTFMove(domain)](auto& keyAndValue) { ditto, should be &domain. > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:188 > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) ditto, could be written on 1 line.

John Wilander

Comment 4 2019-04-23 16:37:40 PDT

(In reply to Chris Dumez from comment #3) > Comment on attachment 368076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368076&action=review > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:181 > > + m_unconvertedAdClickAttributionMap.removeIf([domain = domain](auto& keyAndValue) { > > domain = domain > should be > &domain > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:182 > > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) > > could be written on one line: > return keyAndValue.key.first.registrableDomain == domain || > keyAndValue.key.second.registrableDomain == domain; > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:187 > > + m_convertedAdClickAttributionMap.removeIf([domain = WTFMove(domain)](auto& keyAndValue) { > > ditto, should be &domain. > > > Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp:188 > > + if (keyAndValue.key.first.registrableDomain == domain || keyAndValue.key.second.registrableDomain == domain) > > ditto, could be written on 1 line. Thank you, I will fix all these things.

John Wilander

Comment 5 2019-04-23 16:55:01 PDT

Created attachment 368086 [details] Patch for landing

WebKit Commit Bot

Comment 6 2019-04-23 17:13:06 PDT

Comment on attachment 368086 [details] Patch for landing Clearing flags on attachment: 368086 Committed r244572: <https://trac.webkit.org/changeset/244572>

WebKit Commit Bot

Comment 7 2019-04-23 17:13:07 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.