Bug 197209

Summary:

Build fix after r244545

Product:

WebKit

Reporter:

Remy Demarest <rdemarest>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rdemarest, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, thorton: commit-queue+
Better Patch	none
For Real This Time Patch	none

Remy Demarest

Reported 2019-04-23 13:09:37 PDT

I broke the build in High Sierra with my r244545 patch.

Attachments
Patch (972 bytes, patch) 2019-04-23 13:10 PDT, Remy Demarest	thorton: review+ thorton: commit-queue+	Details Formatted Diff Diff
Better Patch (1.27 KB, patch) 2019-04-23 13:16 PDT, Remy Demarest	no flags	Details Formatted Diff Diff
For Real This Time Patch (1.15 KB, patch) 2019-04-23 13:22 PDT, Remy Demarest	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Remy Demarest

Comment 1 2019-04-23 13:10:07 PDT

Created attachment 368055 [details] Patch

EWS Watchlist

Comment 2 2019-04-23 13:12:37 PDT

Attachment 368055 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:60: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Remy Demarest

Comment 3 2019-04-23 13:16:29 PDT

Created attachment 368056 [details] Better Patch

EWS Watchlist

Comment 4 2019-04-23 13:20:17 PDT

Attachment 368056 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:45: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:62: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Remy Demarest

Comment 5 2019-04-23 13:22:10 PDT

Created attachment 368057 [details] For Real This Time Patch

EWS Watchlist

Comment 6 2019-04-23 13:23:26 PDT

Attachment 368057 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:50: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:62: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 7 2019-04-23 13:47:48 PDT

Comment on attachment 368057 [details] For Real This Time Patch Clearing flags on attachment: 368057 Committed r244564: <https://trac.webkit.org/changeset/244564>

WebKit Commit Bot

Comment 8 2019-04-23 13:47:50 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2019-04-23 13:48:18 PDT

<rdar://problem/50142673>

Note You need to log in before you can comment on or make changes to this bug.