| Summary: | [ews-build] Add unit tests for UnApplyPatchIfRequired | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-04-23 07:41:59 PDT
Created attachment 368029 [details]
Patch
Attachment 368029 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:839: [TestUnApplyPatchIfRequired.test_success] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:852: [TestUnApplyPatchIfRequired.test_failure] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:866: [TestUnApplyPatchIfRequired.test_skip] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 9 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r244551: <https://trac.webkit.org/changeset/244551> |