Bug 197197

Summary:

[ews-build] Add unit tests for UnApplyPatchIfRequired

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	lforschler: review+

Aakash Jain

Reported 2019-04-23 07:41:59 PDT

Add unit tests for UnApplyPatchIfRequired build step.

Attachments
Patch (2.70 KB, patch) 2019-04-23 07:43 PDT, Aakash Jain	lforschler: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-23 07:43:42 PDT

Created attachment 368029 [details] Patch

EWS Watchlist

Comment 2 2019-04-23 07:46:17 PDT Comment hidden (obsolete)

Attachment 368029 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:839: [TestUnApplyPatchIfRequired.test_success] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:852: [TestUnApplyPatchIfRequired.test_failure] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:866: [TestUnApplyPatchIfRequired.test_skip] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 9 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 3 2019-04-23 11:02:58 PDT

Committed r244551: <https://trac.webkit.org/changeset/244551>

Radar WebKit Bug Importer

Comment 4 2019-04-23 11:05:10 PDT

<rdar://problem/50136409>

Note You need to log in before you can comment on or make changes to this bug.