Bug 197196

Summary: REGRESSION (iOS 12.2): BackForwardItemList out of sync when navigating to a failed URL
Product: WebKit Reporter: gambard
Component: HistoryAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Major CC: achristensen, beidson, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Attachments:
Description Flags
Sample app none

Description gambard 2019-04-23 07:31:25 PDT 
Created attachment 368028 [details]
Sample app

Summary:
When navigating forward to a URL failing on webView:didFailProvisionalNavigation:withError: (and which wasn't failing the first time), the BackForwardItemList.currentItem is wrong (i.e. it is the same as if the navigation succeed). The URL of the webView is correct.
The test app is using default WebKit for convenience.

PLEASE NOTE:
The test app is using the bug referenced in https://bugs.webkit.org/show_bug.cgi?id=197097 to navigate to a failed URL. Fixing 197097 will only make the navigation successful, I don't think it will solve the issue. This bugs appeared in iOS 12.2 so the test app needs iOS 12.2.

Steps to Reproduce:
1. Open the sample app (loads https://rsolomakhin.github.io/autofill/)
2. File the first form
3. Submit the form
4. Reload the page (press the "R" in the top toolbar)
5. Go back (press "<" in the top toolbar)
6. Go forward (press ">" in the top toolbar)
7. Tap "Display URL"

Expected Results:
The URL from the back forward current item should be the same as the URL of the WebView.

Actual Results:
The URL of the back forward current item is the item of the destination (i.e. the failed navigation).

I have filed radar 50128898.