Summary: | [ews-build] Add unit tests for CleanWorkingDirectory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2019-04-23 07:01:37 PDT
Created attachment 368026 [details]
Patch
Attachment 368026 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:839: [TestCleanWorkingDirectory.test_success] Undefined variable 'CleanWorkingDirectory' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:846: [TestCleanWorkingDirectory.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:846: [TestCleanWorkingDirectory.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:850: [TestCleanWorkingDirectory.test_failure] Undefined variable 'CleanWorkingDirectory' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:858: [TestCleanWorkingDirectory.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:858: [TestCleanWorkingDirectory.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 6 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 368026 [details] Patch Clearing flags on attachment: 368026 Committed r244550: <https://trac.webkit.org/changeset/244550> All reviewed patches have been landed. Closing bug. |