Summary: | Delayed WebProcessLaunch may break the _relatedWebView SPI | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, ryanhaddad, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 197393 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Chris Dumez
2019-04-22 09:03:08 PDT
Created attachment 367943 [details]
Patch
Comment on attachment 367943 [details] Patch Clearing flags on attachment: 367943 Committed r244502: <https://trac.webkit.org/changeset/244502> All reviewed patches have been landed. Closing bug. This change caused layout test and API test crashes: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010e41de34 WebKit::WebPageProxy::creationParameters(WebKit::WebProcessProxy&, WebKit::DrawingAreaProxy&) + 416 (WebPageProxy.cpp:7026) 1 com.apple.WebKit 0x000000010e44f205 WTF::Function<void (WTF::RefPtr<WebKit::WebPageProxy, WTF::DumbPtrTraits<WebKit::WebPageProxy> >&&)>::CallableWrapper<WebKit::WebPageProxy::createNewPage(WebKit::FrameInfoData const&, unsigned long long, WebCore::ResourceRequest&&, WebCore::WindowFeatures&&, WebKit::NavigationActionData&&, WTF::CompletionHandler<void (unsigned long long, WTF::Optional<WebKit::WebPageCreationParameters> const&)>&&)::$_3>::call(WTF::RefPtr<WebKit::WebPageProxy, WTF::DumbPtrTraits<WebKit::WebPageProxy> >&&) + 97 (Function.h:102) 2 com.apple.WebKit 0x000000010e4a2fa7 WKPageSetPageUIClient::UIClient::createNewPage(WebKit::WebPageProxy&, WebCore::WindowFeatures&&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::CompletionHandler<void (WTF::RefPtr<WebKit::WebPageProxy, WTF::DumbPtrTraits<WebKit::WebPageProxy> >&&)>&&) + 225 (WKPage.cpp:1486) 3 com.apple.WebKit 0x000000010e43228c WebKit::WebPageProxy::createNewPage(WebKit::FrameInfoData const&, unsigned long long, WebCore::ResourceRequest&&, WebCore::WindowFeatures&&, WebKit::NavigationActionData&&, WTF::CompletionHandler<void (unsigned long long, WTF::Optional<WebKit::WebPageCreationParameters> const&)>&&) + 1678 (WebPageProxy.cpp:5013) 4 com.apple.WebKit 0x000000010e67a2f7 WebKit::WebPageProxy::didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >&) + 3007 (HandleMessage.h:149) https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/3754 Reverted r244502 for reason: Caused crashes on the bots Committed r244510: <https://trac.webkit.org/changeset/244510> Created attachment 367976 [details]
Patch
Created attachment 367977 [details]
Patch
Comment on attachment 367977 [details] Patch Rejecting attachment 367977 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 367977, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11965057 Created attachment 367980 [details]
Patch
Comment on attachment 367980 [details] Patch Clearing flags on attachment: 367980 Committed r244516: <https://trac.webkit.org/changeset/244516> All reviewed patches have been landed. Closing bug. |