WebKitGTK+ build fails

• Component: New Bugs
• Status: RESOLVED INVALID

[Tuti]

Perhaps I'm doing something wrong, but I can't get it to build (on Ubuntu 16.04)

cmake command:
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=. -DCMAKE_SKIP_RPATH=ON -DPORT=GTK -DLIB_INSTALL_DIR=./lib -DUSE_LIBHYPHEN=OFF -DENABLE_MINIBROWSER=ON -DUSE_SYSTEM_MALLOC=ON -DENABLE_GEOLOCATION=OFF -DENABLE_GTKDOC=OFF -DENABLE_INTROSPECTION=OFF -DENABLE_OPENGL=OFF -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_CREDENTIAL_STORAGE=OFF -DENABLE_GAMEPAD_DEPRECATED=OFF -DENABLE_MEDIA_STREAM=OFF -DENABLE_WEB_RTC=OFF -DENABLE_PLUGIN_PROCESS_GTK2=OFF -DENABLE_SPELLCHECK=OFF -DENABLE_VIDEO=OFF -DENABLE_WEB_AUDIO=OFF -DUSE_LIBNOTIFY=OFF -DENABLE_SUBTLE_CRYPTO=OFF -DUSE_WOFF2=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DUSE_OPENJPEG=OFF -Wno-dev ..


build error:
WebKit/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:34:10: fatal error: 'WebCore/GStreamerCommon.h' file not found
#include <WebCore/GStreamerCommon.h>

[Philippe Normand]

Created attachment 368220 [details]
patch

Can you try this?

[Tuti]

Thanks.

Tried unsuccessfully:
[100%] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-31.cpp.o
In file included from /WebKit/build/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-31.cpp:3:
/WebKit/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:31:10: fatal error: 'WebCore/GStreamerCommon.h' file not found
#include <WebCore/GStreamerCommon.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Source/WebKit/CMakeFiles/WebKit.dir/build.make:10917: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-31.cpp.o' failed
make[2]: *** [Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-31.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /WebKit/build/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-29.cpp:6:
In file included from /WebKit/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:32:
/WebKit/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:176:14: warning: private field 'm_webPage' is not used [-Wunused-private-field]
    WebPage& m_webPage;
             ^
1 warning generated.
In file included from /WebKit/Source/WebKit/WebProcess/WebPage/WebPage.cpp:167:
In file included from /WebKit/build/DerivedSources/ForwardingHeaders/WebCore/GraphicsContext3D.h:28:
/WebKit/build/DerivedSources/ForwardingHeaders/WebCore/ANGLEWebKitBridge.h:35:10: fatal error: 'ANGLE/ShaderLang.h' file not found
#include <ANGLE/ShaderLang.h>
         ^~~~~~~~~~~~~~~~~~~~
1 error generated.
Source/WebKit/CMakeFiles/WebKit.dir/build.make:10797: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/WebPage/WebPage.cpp.o' failed
make[2]: *** [Sour

I forgot to mention I am building using the following patch:
https://github.com/googleprojectzero/p0tools/tree/master/WebKitFuzz

What seems to be breaking the build are the changes made to Source/WebKit/PlatformGTK.cmake

[Tuti]

And this is the cmake command

cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=. -DCMAKE_SKIP_RPATH=ON -DPORT=GTK -DLIB_INSTALL_DIR=./lib -DUSE_LIBHYPHEN=OFF -DENABLE_MINIBROWSER=ON -DUSE_SYSTEM_MALLOC=ON -DENABLE_GEOLOCATION=OFF -DENABLE_GTKDOC=OFF -DENABLE_INTROSPECTION=OFF -DENABLE_OPENGL=OFF -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_CREDENTIAL_STORAGE=OFF -DENABLE_GAMEPAD_DEPRECATED=OFF -DENABLE_MEDIA_STREAM=OFF -DENABLE_WEB_RTC=OFF -DENABLE_PLUGIN_PROCESS_GTK2=OFF -DENABLE_SPELLCHECK=OFF -DENABLE_VIDEO=OFF -DENABLE_WEB_AUDIO=OFF -DUSE_LIBNOTIFY=OFF -DENABLE_SUBTLE_CRYPTO=OFF -DUSE_WOFF2=OFF -DENABLE_BUBBLEWRAP_^CNDBOX=OFF -DUSE_OPENJPEG=OFF -Wno-dev ..