Bug 197140

Summary: Update text for old EWS submit button
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dewei_zhu, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-04-20 09:24:32 PDT
The text for new EWS submit button is 'Submit to new EWS'. To be consistent, and less confusing for new developers, the text for old EWS submit button should be 'Submit to old EWS'.
Attachments
Patch (1.23 KB, patch)
2019-04-20 09:25 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-20 09:25:08 PDT
Created attachment 367890 [details] Patch
Alexey Proskuryakov
Comment 2 2019-04-20 10:22:18 PDT
Comment on attachment 367890 [details] Patch Has there been feedback suggesting this? I’m not sure if old/new is an important distinction for WebKit developers - what seems important to me is which tests are triggered by which button. It may be ok to treat this temporary state where we have two as transitional, and not over-optimize it. Longer term, this button name should be tweaked to be more clear on two things: 1. It doesn’t need to be pressed if the attachment is a patch for review. 2. What EWS even is in the first place.
Aakash Jain
Comment 3 2019-04-20 11:08:38 PDT
> Has there been feedback suggesting this? Nope. It was a just a quick fix, as I was working on this code. > I’m not sure if old/new is an important distinction for WebKit developers - what seems important to me is which tests are triggered by which button. > > It may be ok to treat this temporary state where we have two as transitional, and not over-optimize it. Yeah. > Longer term, this button name should be tweaked to be more clear on two things: > > 1. It doesn’t need to be pressed if the attachment is a patch for review. https://bugs.webkit.org/show_bug.cgi?id=197138 would make this button appear less frequently in such cases. Maybe in future we can make bugzilla send push events to EWS, so that this button doesn't appear at all. > 2. What EWS even is in the first place. Agree.
WebKit Commit Bot
Comment 4 2019-04-20 11:44:59 PDT
Comment on attachment 367890 [details] Patch Clearing flags on attachment: 367890 Committed r244487: <https://trac.webkit.org/changeset/244487>
WebKit Commit Bot
Comment 5 2019-04-20 11:45:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-04-20 11:45:18 PDT
<rdar://problem/50074153>
Note You need to log in before you can comment on or make changes to this bug.