Bug 197072

Summary: Add postprocess-header-rule scripts
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, ews-watchlist, keith_miller, lforschler, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews202 for win-future none

Description Keith Rollin 2019-04-18 13:53:45 PDT
Several projects have post-processing build phases where exported headers are tweaked after they've been copied. This post-processing is performed via scripts called postprocess-headers.sh. We are now transitioning to a build process where the post-processing is performed at the same time as the exporting/copying. To support this process, add similar scripts named postprocess-header-rule, which are geared towards processing a single file at a time rather than all exported files at once. These scripts are not used at the moment; they will come into use in an imminent patch.

Note that I've named these postprocess-header-rule rather than postprocess-header-rule.sh. Scripts in Tools/Scripts do not have suffixes indicating how the tool is implemented. Scripts in per-project Scripts folders appear to be mixed regarding the use of suffixes. I'm opting here to follow the Tools/Scripts convention, with the expectation that over time we completely standardize on that.
Comment 1 Radar WebKit Bug Importer 2019-04-18 13:53:54 PDT
<rdar://problem/50027299>
Comment 2 Keith Rollin 2019-04-18 13:55:10 PDT
> We are now transitioning to a build process where the post-processing is performed at the same time as the exporting/copying.

Because of XCBuild.
Comment 3 Keith Rollin 2019-04-18 13:57:35 PDT
Created attachment 367751 [details]
Patch
Comment 4 Keith Rollin 2019-04-18 14:07:49 PDT
Comment on attachment 367751 [details]
Patch

This patch is incomplete. Taking it down.
Comment 5 Keith Rollin 2019-04-18 14:13:48 PDT
I want to add that a build rule is also being added that makes use of these scripts. This build rule is not currently active, but will be later.
Comment 6 Keith Rollin 2019-04-18 14:17:15 PDT
Created attachment 367755 [details]
Patch
Comment 7 EWS Watchlist 2019-04-18 16:14:38 PDT
Comment on attachment 367755 [details]
Patch

Attachment 367755 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11920186

New failing tests:
js/dom/custom-constructors.html
Comment 8 EWS Watchlist 2019-04-18 16:14:50 PDT
Created attachment 367771 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 9 Keith Rollin 2019-04-18 17:26:21 PDT
My changes here don't affect Windows, so turning off cq-.
Comment 10 Brent Fulgham 2019-04-19 13:51:24 PDT
(In reply to Keith Rollin from comment #9)
> My changes here don't affect Windows, so turning off cq-.

Agreed. Windows is CMake.
Comment 11 WebKit Commit Bot 2019-04-19 14:07:36 PDT
Comment on attachment 367755 [details]
Patch

Clearing flags on attachment: 367755

Committed r244466: <https://trac.webkit.org/changeset/244466>
Comment 12 WebKit Commit Bot 2019-04-19 14:07:38 PDT
All reviewed patches have been landed.  Closing bug.