Bug 197059

Summary:

Bug to test new EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed Patch	none
Proposed patch	none
Updated patch	none
Fix build failures	none
Proposed patch	none
Proposed patch	none

Description Aakash Jain 2019-04-18 09:16:02 PDT

Increase timeout for WebKitPerl Tests.

Comment 1 Aakash Jain 2019-04-18 09:46:43 PDT

Created attachment 367731 [details]
Proposed patch

Comment 2 Aakash Jain 2019-04-18 09:59:06 PDT

Created attachment 367733 [details]
Proposed Patch

Comment 3 Aakash Jain 2019-04-18 11:37:27 PDT

Created attachment 367740 [details]
Proposed patch

Comment 4 Aakash Jain 2019-04-24 10:35:13 PDT

Created attachment 368139 [details]
Updated patch

Comment 5 Aakash Jain 2019-04-24 10:38:30 PDT

Note that this is a bug to test EWS.

Comment 6 Aakash Jain 2019-04-24 11:00:13 PDT

Created attachment 368144 [details]
Fix build failures

Comment 7 Aakash Jain 2019-04-24 11:13:07 PDT

Created attachment 368145 [details]
Proposed patch

Comment 8 EWS Watchlist 2019-04-24 15:00:05 PDT Comment hidden (obsolete)

Attachment 368145 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CheckedArithmetic.h:395:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Aakash Jain 2019-04-24 16:11:30 PDT

Created attachment 368194 [details]
Proposed patch

Comment 10 EWS Watchlist 2019-04-24 16:15:10 PDT Comment hidden (obsolete)

Attachment 368194 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CheckedArithmetic.h:395:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.