Bug 197059

Summary:

Bug to test new EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed Patch	none
Proposed patch	none
Updated patch	none
Fix build failures	none
Proposed patch	none
Proposed patch	none

Aakash Jain

Reported 2019-04-18 09:16:02 PDT

Increase timeout for WebKitPerl Tests.

Attachments
Proposed patch (1.21 KB, patch) 2019-04-18 09:46 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed Patch (1.21 KB, patch) 2019-04-18 09:59 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (1.21 KB, patch) 2019-04-18 11:37 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (1.61 KB, patch) 2019-04-24 10:35 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Fix build failures (1.80 KB, patch) 2019-04-24 11:00 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (19.33 KB, patch) 2019-04-24 11:13 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (19.33 KB, patch) 2019-04-24 16:11 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-18 09:46:43 PDT

Created attachment 367731 [details] Proposed patch

Aakash Jain

Comment 2 2019-04-18 09:59:06 PDT

Created attachment 367733 [details] Proposed Patch

Aakash Jain

Comment 3 2019-04-18 11:37:27 PDT

Created attachment 367740 [details] Proposed patch

Aakash Jain

Comment 4 2019-04-24 10:35:13 PDT

Created attachment 368139 [details] Updated patch

Aakash Jain

Comment 5 2019-04-24 10:38:30 PDT

Note that this is a bug to test EWS.

Aakash Jain

Comment 6 2019-04-24 11:00:13 PDT

Created attachment 368144 [details] Fix build failures

Aakash Jain

Comment 7 2019-04-24 11:13:07 PDT

Created attachment 368145 [details] Proposed patch

EWS Watchlist

Comment 8 2019-04-24 15:00:05 PDT Comment hidden (obsolete)

Attachment 368145 [details] did not pass style-queue: ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 9 2019-04-24 16:11:30 PDT

Created attachment 368194 [details] Proposed patch

EWS Watchlist

Comment 10 2019-04-24 16:15:10 PDT Comment hidden (obsolete)

Attachment 368194 [details] did not pass style-queue: ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Note You need to log in before you can comment on or make changes to this bug.