Bug 197028

Summary:

[iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing

Product:

WebKit

Reporter:

Shawn Roberts <sroberts>

Component:

WebKit API

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jlewis3, ryanhaddad, simon.fraser, thorton, tsavell, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Shawn Roberts 2019-04-17 11:30:01 PDT

New API test TestWebKitAPI.WebKit.OverrideViewportArguments added in https://trac.webkit.org/changeset/244151 is failing on iOS Simulator Debug

https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/3239/steps/run-api-tests/logs/stdio

Is failing every run on the bots, is a flaky failure when run locally.

TestWebKitAPI.WebKit.OverrideViewportArguments
        2019-04-10 17:41:45.743 TestWebKitAPI[3470:6770579] -[WKWebView _overrideViewportWithArguments:]: Error parsing viewport argument: Viewport argument key "garbage" not recognized and ignored.
        LEAK: 1 WebProcessPool
        LEAK: 1 WebPageProxy
        
        /Volumes/Data/slave/ios-simulator-12-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:54
        Expected equality of these values:
          1.
            Which is: 1
          [webView scrollView].zoomScale
            Which is: 0.25

Comment 1 Radar WebKit Bug Importer 2019-04-17 11:33:50 PDT

<rdar://problem/49985290>

Comment 2 Tim Horton 2019-04-17 17:22:16 PDT

Created attachment 367702 [details]
Patch

Comment 3 WebKit Commit Bot 2019-04-17 18:02:58 PDT

Comment on attachment 367702 [details]
Patch

Clearing flags on attachment: 367702

Committed r244415: <https://trac.webkit.org/changeset/244415>

Comment 4 WebKit Commit Bot 2019-04-17 18:02:59 PDT

All reviewed patches have been landed.  Closing bug.