Bug 197017

Summary:

Refactoring: Pull all fullscreen code out of Document and into its own helper class

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from ews204 for win-future	none
Patch for landing	none
Archive of layout-test-results from ews200 for win-future	none
Patch for landing	none

Jer Noble

Reported 2019-04-17 09:48:22 PDT

Refactoring: Pull all fullscreen code out of Document and into its own helper class

Attachments
Patch (90.79 KB, patch) 2019-04-17 10:07 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (123.02 KB, patch) 2019-04-17 10:11 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (122.76 KB, patch) 2019-04-17 10:29 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (121.82 KB, patch) 2019-04-17 10:58 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (121.74 KB, patch) 2019-04-17 11:29 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (121.63 KB, patch) 2019-04-17 11:59 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (126.07 KB, patch) 2019-04-17 12:28 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (126.36 KB, patch) 2019-04-17 13:03 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (126.62 KB, patch) 2019-04-17 14:19 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (127.02 KB, patch) 2019-04-17 15:50 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.94 MB, application/zip) 2019-04-17 18:05 PDT, EWS Watchlist	no flags	Details
Patch for landing (127.02 KB, patch) 2019-04-17 19:59 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.94 MB, application/zip) 2019-04-17 22:01 PDT, EWS Watchlist	no flags	Details
Patch for landing (127.53 KB, patch) 2019-04-17 22:12 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2019-04-17 10:07:07 PDT

Created attachment 367640 [details] Patch

Jer Noble

Comment 2 2019-04-17 10:11:43 PDT

Created attachment 367642 [details] Patch

Jer Noble

Comment 3 2019-04-17 10:29:19 PDT

Created attachment 367647 [details] Patch

Eric Carlson

Comment 4 2019-04-17 10:38:21 PDT

Comment on attachment 367647 [details] Patch r=me once the bots are happy

Jer Noble

Comment 5 2019-04-17 10:58:37 PDT

Created attachment 367650 [details] Patch for landing

Jer Noble

Comment 6 2019-04-17 11:29:19 PDT

Created attachment 367657 [details] Patch for landing

Jer Noble

Comment 7 2019-04-17 11:59:39 PDT

Created attachment 367660 [details] Patch for landing

Jer Noble

Comment 8 2019-04-17 12:28:39 PDT

Created attachment 367663 [details] Patch for landing

Jer Noble

Comment 9 2019-04-17 13:03:21 PDT

Created attachment 367666 [details] Patch for landing

Jer Noble

Comment 10 2019-04-17 14:19:59 PDT

Created attachment 367678 [details] Patch for landing

Jer Noble

Comment 11 2019-04-17 15:50:15 PDT

Created attachment 367689 [details] Patch for landing

EWS Watchlist

Comment 12 2019-04-17 18:05:32 PDT Comment hidden (obsolete)

Comment on attachment 367689 [details] Patch for landing Attachment 367689 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11907940 New failing tests: accessibility/insert-children-assert.html fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html storage/indexeddb/modern/gc-closes-database.html fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html

EWS Watchlist

Comment 13 2019-04-17 18:05:44 PDT Comment hidden (obsolete)

Created attachment 367709 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Jer Noble

Comment 14 2019-04-17 19:59:12 PDT

Created attachment 367714 [details] Patch for landing

EWS Watchlist

Comment 15 2019-04-17 22:01:47 PDT Comment hidden (obsolete)

Comment on attachment 367714 [details] Patch for landing Attachment 367714 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11910544 New failing tests: accessibility/insert-children-assert.html fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html

EWS Watchlist

Comment 16 2019-04-17 22:01:59 PDT Comment hidden (obsolete)

Created attachment 367716 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Jer Noble

Comment 17 2019-04-17 22:12:46 PDT

Created attachment 367718 [details] Patch for landing

WebKit Commit Bot

Comment 18 2019-04-18 15:17:14 PDT

Comment on attachment 367718 [details] Patch for landing Clearing flags on attachment: 367718 Committed r244440: <https://trac.webkit.org/changeset/244440>

WebKit Commit Bot

Comment 19 2019-04-18 15:17:19 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 20 2019-04-18 15:18:47 PDT

<rdar://problem/50030423>

Note You need to log in before you can comment on or make changes to this bug.