| Summary: | Refactoring: Pull all fullscreen code out of Document and into its own helper class | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer | ||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||
|
Description
Jer Noble
2019-04-17 09:48:22 PDT
Created attachment 367640 [details]
Patch
Created attachment 367642 [details]
Patch
Created attachment 367647 [details]
Patch
Comment on attachment 367647 [details]
Patch
r=me once the bots are happy
Created attachment 367650 [details]
Patch for landing
Created attachment 367657 [details]
Patch for landing
Created attachment 367660 [details]
Patch for landing
Created attachment 367663 [details]
Patch for landing
Created attachment 367666 [details]
Patch for landing
Created attachment 367678 [details]
Patch for landing
Created attachment 367689 [details]
Patch for landing
Comment on attachment 367689 [details] Patch for landing Attachment 367689 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11907940 New failing tests: accessibility/insert-children-assert.html fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html storage/indexeddb/modern/gc-closes-database.html fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html Created attachment 367709 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 367714 [details]
Patch for landing
Comment on attachment 367714 [details] Patch for landing Attachment 367714 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11910544 New failing tests: accessibility/insert-children-assert.html fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html Created attachment 367716 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 367718 [details]
Patch for landing
Comment on attachment 367718 [details] Patch for landing Clearing flags on attachment: 367718 Committed r244440: <https://trac.webkit.org/changeset/244440> All reviewed patches have been landed. Closing bug. |