Bug 197005

Summary:

[Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

UI Events

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Patch	dino: review+

Antoine Quint

Reported 2019-04-17 07:03:05 PDT

The test at imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html is timing out and is currently skipped.

Attachments
Patch (16.58 KB, patch) 2019-06-24 04:51 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (16.58 KB, patch) 2019-06-24 05:01 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (16.59 KB, patch) 2019-06-24 05:47 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.30 MB, application/zip) 2019-06-24 06:36 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.71 MB, application/zip) 2019-06-24 07:07 PDT, EWS Watchlist	no flags	Details
Patch (21.19 KB, patch) 2019-06-24 08:30 PDT, Antoine Quint	dino: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2019-06-24 04:51:33 PDT

Created attachment 372743 [details] Patch

Antoine Quint

Comment 2 2019-06-24 05:01:58 PDT

Created attachment 372744 [details] Patch

Antoine Quint

Comment 3 2019-06-24 05:47:59 PDT

Created attachment 372747 [details] Patch

Antoine Quint

Comment 4 2019-06-24 05:50:01 PDT

This test assumes that the pointerlockchange event is dispatched synchronously after calling requestPointerLock(). This is the reason it's timing out. It still fails afterwards though, so there is work to do.

Antoine Quint

Comment 5 2019-06-24 05:50:40 PDT

The last comment was meant for https://bugs.webkit.org/show_bug.cgi?id=197007.

EWS Watchlist

Comment 6 2019-06-24 06:36:52 PDT

Comment on attachment 372747 [details] Patch Attachment 372747 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12561431 New failing tests: imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover.html

EWS Watchlist

Comment 7 2019-06-24 06:36:54 PDT

Created attachment 372751 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-06-24 07:07:02 PDT

Comment on attachment 372747 [details] Patch Attachment 372747 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12561524 New failing tests: pointerevents/mouse/pointer-capture.html

EWS Watchlist

Comment 9 2019-06-24 07:07:04 PDT

Created attachment 372754 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Antoine Quint

Comment 10 2019-06-24 08:30:57 PDT

Created attachment 372765 [details] Patch

EWS Watchlist

Comment 11 2019-06-24 08:32:23 PDT

Attachment 372765 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antoine Quint

Comment 12 2019-06-24 12:00:26 PDT

Committed r246752: <https://trac.webkit.org/changeset/246752>

Radar WebKit Bug Importer

Comment 13 2019-06-24 12:02:36 PDT

<rdar://problem/52063896>

Note You need to log in before you can comment on or make changes to this bug.