Summary: | Make roundUpToPowerOfTwo work with Checked arithmetic classes | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
Component: | Web Template Framework | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
Status: | NEW --- | ||||||||||||||
Severity: | Normal | CC: | darin, ews-watchlist, ggaren, keith_miller, saam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 196935 | ||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2019-04-16 22:20:20 PDT
Created attachment 367613 [details]
Patch
Attachment 367613 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 7 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367614 [details]
GCC build fix attempt
Attachment 367614 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 7 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367614 [details] GCC build fix attempt Attachment 367614 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11896632 Number of test failures exceeded the failure limit. Created attachment 367617 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367614 [details] GCC build fix attempt Attachment 367614 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11896717 Number of test failures exceeded the failure limit. Created attachment 367618 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367614 [details]
GCC build fix attempt
Oops, looks like I broke things.
Created attachment 367713 [details]
Fixed the tests
Attachment 367713 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 7 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367713 [details]
Fixed the tests
This seems like way more code than just doing the dumb way of checking for unsigned overflow...
|