| Summary: | -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, ews-watchlist, sihui_liu, webkit-bug-importer, wilander | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Per Arne Vollan
2019-04-16 15:49:57 PDT
Created attachment 367591 [details]
Patch
Comment on attachment 367591 [details]
Patch
r=me
Comment on attachment 367591 [details]
Patch
Thanks for reviewing!
Comment on attachment 367591 [details] Patch We should refactor computeNetworkProcessAccessTypeForDataFetch() to make use of WebsiteData::ownerProcess(dataType) which I added in https://trac.webkit.org/changeset/243632/webkit. See computeNetworkProcessAccessTypeForDataRemoval() in WebKit::WebsiteDataStore.cpp for an example. Comment on attachment 367591 [details] Patch Clearing flags on attachment: 367591 Committed r244365: <https://trac.webkit.org/changeset/244365> All reviewed patches have been landed. Closing bug. (In reply to John Wilander from comment #5) > Comment on attachment 367591 [details] > Patch > > We should refactor computeNetworkProcessAccessTypeForDataFetch() to make use > of WebsiteData::ownerProcess(dataType) which I added in > https://trac.webkit.org/changeset/243632/webkit. See > computeNetworkProcessAccessTypeForDataRemoval() in > WebKit::WebsiteDataStore.cpp for an example. I see, that would probably simplify the implementation a bit! Reopening to attach new patch. Created attachment 367981 [details]
Patch
Comment on attachment 367981 [details] Patch Please add a test. See https://bugs.webkit.org/show_bug.cgi?id=197093 for an example of a test for doing things with credentials. (In reply to Alex Christensen from comment #11) > Comment on attachment 367981 [details] > Patch > > Please add a test. See https://bugs.webkit.org/show_bug.cgi?id=197093 for > an example of a test for doing things with credentials. Thanks for reviewing! I am looking into adding a test similar to the test in https://bugs.webkit.org/show_bug.cgi?id=197093, but it seems the credential is not being stored. Created attachment 368085 [details]
Patch
Created attachment 368176 [details]
Patch
It looks like GTK/WPE are unhappy because of ISOHeapInlines.h? Created attachment 368188 [details]
Patch
I think this looks fine, but Alex should review this. Created attachment 368240 [details]
Patch
Thanks for reviewing, Alex! Comment on attachment 368240 [details] Patch Attachment 368240 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11995934 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-abort.https.html Created attachment 368251 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #20) > Comment on attachment 368240 [details] > Patch > > Attachment 368240 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: https://webkit-queues.webkit.org/results/11995934 > > New failing tests: > imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache- > abort.https.html I think this failure in unrelated. Committed r244659: <https://trac.webkit.org/changeset/244659/webkit> |