Bug 196962

Summary:

Unprefix -webkit-sticky

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

CSS

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none

Devin Rousso

Reported 2019-04-16 01:12:23 PDT

Attachments
Patch (48.66 KB, patch) 2019-04-16 01:44 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.20 MB, application/zip) 2019-04-16 02:51 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.96 MB, application/zip) 2019-04-16 03:13 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (3.38 MB, application/zip) 2019-04-16 03:40 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews206 for win-future (12.90 MB, application/zip) 2019-04-16 06:43 PDT, EWS Watchlist	no flags	Details
Patch (48.54 KB, patch) 2019-04-16 11:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-04-16 01:12:40 PDT

<rdar://problem/40903458>

Devin Rousso

Comment 2 2019-04-16 01:44:50 PDT

Created attachment 367515 [details] Patch

EWS Watchlist

Comment 3 2019-04-16 02:51:27 PDT Comment hidden (obsolete)

Comment on attachment 367515 [details] Patch Attachment 367515 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11883321 New failing tests: fast/css/sticky/parsing-position-sticky.html

EWS Watchlist

Comment 4 2019-04-16 02:51:29 PDT Comment hidden (obsolete)

Created attachment 367521 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-04-16 03:13:55 PDT Comment hidden (obsolete)

Comment on attachment 367515 [details] Patch Attachment 367515 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11883467 New failing tests: fast/css/sticky/parsing-position-sticky.html

EWS Watchlist

Comment 6 2019-04-16 03:13:56 PDT Comment hidden (obsolete)

Created attachment 367522 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-04-16 03:40:53 PDT Comment hidden (obsolete)

Comment on attachment 367515 [details] Patch Attachment 367515 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11883465 New failing tests: fast/css/sticky/parsing-position-sticky.html

EWS Watchlist

Comment 8 2019-04-16 03:40:55 PDT Comment hidden (obsolete)

Created attachment 367524 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-04-16 06:43:17 PDT Comment hidden (obsolete)

Comment on attachment 367515 [details] Patch Attachment 367515 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11885137 New failing tests: fast/css/sticky/parsing-position-sticky.html

EWS Watchlist

Comment 10 2019-04-16 06:43:28 PDT Comment hidden (obsolete)

Created attachment 367533 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Simon Fraser (smfr)

Comment 11 2019-04-16 10:23:00 PDT

Comment on attachment 367515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367515&action=review > LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt:6 > -PASS test("position: -webkit-sticky;") is "-webkit-sticky" > +PASS test("position: sticky;") is "sticky" The test that produces this result still needs to test the parsing of the legacy -webkit-sticky value.

Devin Rousso

Comment 12 2019-04-16 11:29:15 PDT

Created attachment 367548 [details] Patch

WebKit Commit Bot

Comment 13 2019-04-16 12:48:43 PDT

Comment on attachment 367548 [details] Patch Clearing flags on attachment: 367548 Committed r244353: <https://trac.webkit.org/changeset/244353>

WebKit Commit Bot

Comment 14 2019-04-16 12:48:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.