| Summary: | Web Inspector: DOM Nodes should not show $0 when selected in Console area | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Joseph Pecoraro
2019-04-15 20:02:30 PDT
Steps to Reproduce: 1. Log an element to the console 2. Click the element => the "= $0" overlaps the "= $1" => it isn't really the $0 Created attachment 367489 [details]
[IMAGE] Before
Created attachment 367490 [details]
[IMAGE] After
Created attachment 367491 [details]
[PATCH] Proposed Fix
Comment on attachment 367491 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=367491&action=review rs=me > Source/WebInspectorUI/ChangeLog:13 > + Make parameters explicit. Drop "selectable" which was always true. It may be worth mentioning (or this comment can suffice) that there were other creators of `WI.DOMTreeOutline`, but due to the fact that `WI.TreeOutline`'s constructor has a default `selectable = true`, passing `undefined` as all three arguments in those cases would fall back to the default `true`, so yes, it was always `true`. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:66 > + this._domTreeOutline = new WI.DOMTreeOutline({omitRootDOMNode: true, excludeRevealElementContextMenu: true, showLastSelected: true}); Nice! Comment on attachment 367491 [details] [PATCH] Proposed Fix Clearing flags on attachment: 367491 Committed r244327: <https://trac.webkit.org/changeset/244327> All reviewed patches have been landed. Closing bug. |