| Summary: | [Web GPU] Add demos to webkit.org | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||||||||
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, mmaxfield, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Justin Fan
2019-04-15 18:28:35 PDT
Created attachment 367486 [details]
Patch
Created attachment 367553 [details]
Patch
Created attachment 367554 [details]
Patch
Comment on attachment 367554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367554&action=review > Websites/webkit.org/ChangeLog:9 > + Add simple triangle and spinning textured cube demos to the website. > + Add Web GPU to experimental-features.html. There's a lot of green in this patch. What about the existing WebMetal demos? Are we rewriting them? Deleting them? > Websites/webkit.org/demos/webgpu/scripts/gl-matrix-min.js:26 > +/* Copyright (c) 2015, Brandon Jones, Colin MacKenzie IV. > + > +Permission is hereby granted, free of charge, to any person obtaining a copy > +of this software and associated documentation files (the "Software"), to deal > +in the Software without restriction, including without limitation the rights > +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > +copies of the Software, and to permit persons to whom the Software is > +furnished to do so, subject to the following conditions: > + > +The above copyright notice and this permission notice shall be included in > +all copies or substantial portions of the Software. > + > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > +THE SOFTWARE. */ Are we sure this license is okay with our lawyers? It's probably easier to just reimplement the specific pieces we need than deal with licenses. The API request was approved. I'll fix these up for API changes this week before landing this. Created attachment 369048 [details]
Patch
Comment on attachment 369048 [details] Patch Attachment 369048 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12098129 New failing tests: js/dom/custom-constructors.html Created attachment 369069 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 369048 [details]
Patch
rs=me
Comment on attachment 369048 [details] Patch Clearing flags on attachment: 369048 Committed r244992: <https://trac.webkit.org/changeset/244992> All reviewed patches have been landed. Closing bug. |