Bug 196936

Summary: Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents')
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: https://webkit.org/
Attachments:
Description Flags
Patch
joepeck: review+, joepeck: commit-queue-
Archive of layout-test-results from ews204 for win-future
none
Patch none

Description Devin Rousso 2019-04-15 14:31:47 PDT
-------
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)

Uncaught Exceptions:
 - TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents') (at HeapAllocationsTimelineView.js:218:79)
    selectionPathComponents @ HeapAllocationsTimelineView.js:218:79
    _updateContentViewSelectionPathNavigationItem @ ContentBrowser.js:365:64
    _contentViewSelectionPathComponentDidChange @ ContentBrowser.js:485:59
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:180:21
    _timelineDataGridSelectedNodeChanged @ TimelineView.js:313:38
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    select @ DataGridNode.js:568:51
    showHeapSnapshotTimelineRecord @ HeapAllocationsTimelineView.js:156:36
    selectRecord @ HeapAllocationsTimelineView.js:224:48
    _selectRecordInTimelineView @ TimelineRecordingContentView.js:916:42
    _recordSelected @ TimelineRecordingContentView.js:775:41
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    _recordSelected @ TimelineOverview.js:799:38
    _handleOverviewGraphRecordSelected @ TimelineOverview.js:760:29
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    ? @ TimelineOverviewGraph.js:295:42
-------

* STEPS TO REPRODUCE
1. inspect any page
2. go to the Timelines tab
3. enable the JavaScript Allocations timeline
4. take a recording
5. click on one of the [S] heap snapshots in the overview
Comment 1 Radar WebKit Bug Importer 2019-04-15 14:32:34 PDT
<rdar://problem/49917789>
Comment 2 Devin Rousso 2019-04-16 00:43:35 PDT
Created attachment 367507 [details]
Patch
Comment 3 EWS Watchlist 2019-04-16 04:50:26 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2019-04-16 04:50:37 PDT Comment hidden (obsolete)
Comment 5 Joseph Pecoraro 2019-04-16 12:15:14 PDT
Comment on attachment 367507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367507&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:198
> +        if (this._contentViewContainer.CurrentContentViewDidChange)

Seems like a typo. Maybe for:

    this._contentViewContainer.currentContentView
Comment 6 Devin Rousso 2019-04-16 12:23:06 PDT
Created attachment 367555 [details]
Patch
Comment 7 WebKit Commit Bot 2019-04-16 12:53:14 PDT
Comment on attachment 367555 [details]
Patch

Clearing flags on attachment: 367555

Committed r244354: <https://trac.webkit.org/changeset/244354>
Comment 8 WebKit Commit Bot 2019-04-16 12:53:16 PDT
All reviewed patches have been landed.  Closing bug.