Bug 196936 – Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

-------
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)

Uncaught Exceptions:
 - TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents') (at HeapAllocationsTimelineView.js:218:79)
    selectionPathComponents @ HeapAllocationsTimelineView.js:218:79
    _updateContentViewSelectionPathNavigationItem @ ContentBrowser.js:365:64
    _contentViewSelectionPathComponentDidChange @ ContentBrowser.js:485:59
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:180:21
    _timelineDataGridSelectedNodeChanged @ TimelineView.js:313:38
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    select @ DataGridNode.js:568:51
    showHeapSnapshotTimelineRecord @ HeapAllocationsTimelineView.js:156:36
    selectRecord @ HeapAllocationsTimelineView.js:224:48
    _selectRecordInTimelineView @ TimelineRecordingContentView.js:916:42
    _recordSelected @ TimelineRecordingContentView.js:775:41
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    _recordSelected @ TimelineOverview.js:799:38
    _handleOverviewGraphRecordSelected @ TimelineOverview.js:760:29
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    ? @ TimelineOverviewGraph.js:295:42
-------

* STEPS TO REPRODUCE
1. inspect any page
2. go to the Timelines tab
3. enable the JavaScript Allocations timeline
4. take a recording
5. click on one of the [S] heap snapshots in the overview

[Radar WebKit Bug Importer]

<rdar://problem/49917789>

[Devin Rousso]

Created attachment 367507 [details]
Patch

[EWS Watchlist]

Comment on attachment 367507 [details]
Patch

Attachment 367507 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11884358

New failing tests:
storage/indexeddb/modern/gc-closes-database.html

[EWS Watchlist]

Created attachment 367529 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Joseph Pecoraro]

Comment on attachment 367507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367507&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:198
> +        if (this._contentViewContainer.CurrentContentViewDidChange)

Seems like a typo. Maybe for:

    this._contentViewContainer.currentContentView

[Devin Rousso]

Created attachment 367555 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367555 [details]
Patch

Clearing flags on attachment: 367555

Committed r244354: <https://trac.webkit.org/changeset/244354>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.