Bug 196925

Summary:

Web Inspector: REGRESSION(r244172): crash when trying to add extra domain while inspecting JSContext

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, sroberts, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

195971

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2019-04-15 12:06:17 PDT

Comment 1 Devin Rousso 2019-04-15 12:06:36 PDT

<rdar://problem/49873994>

Comment 2 Devin Rousso 2019-04-15 12:10:16 PDT

Created attachment 367439 [details]
Patch

Comment 3 Joseph Pecoraro 2019-04-15 12:12:20 PDT

Comment on attachment 367439 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2019-04-15 13:29:36 PDT

Comment on attachment 367439 [details]
Patch

Clearing flags on attachment: 367439

Committed r244285: <https://trac.webkit.org/changeset/244285>

Comment 5 WebKit Commit Bot 2019-04-15 13:29:37 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Shawn Roberts 2019-04-16 10:45:22 PDT

After changes in https://trac.webkit.org/changeset/244285 

http/tests/inspector/network/har/har-page.html is failing on WK2 Release and Debug builds.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html

Was a flaky timeout/failure in previous revisions. 

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -588,8 +588,7 @@
               "path": "/",
               "expires": "",
               "httpOnly": false,
-              "secure": false,
-              "sameSite": "Strict"
+              "secure": false
             }
           ],
           "headers": "<filtered>",
@@ -661,8 +660,7 @@
               "path": "/",
               "expires": "",
               "httpOnly": false,
-              "secure": false,
-              "sameSite": "Strict"
+              "secure": false
             }
           ],
           "headers": "<filtered>",

Comment 7 Shawn Roberts 2019-04-16 10:52:38 PDT

Disregard last comment. I blamed the wrong revision.