Bug 196925 – Web Inspector: REGRESSION(r244172): crash when trying to add extra domain while inspecting JSContext

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

.

[Devin Rousso]

<rdar://problem/49873994>

[Devin Rousso]

Created attachment 367439 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 367439 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 367439 [details]
Patch

Clearing flags on attachment: 367439

Committed r244285: <https://trac.webkit.org/changeset/244285>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Roberts]

After changes in https://trac.webkit.org/changeset/244285 

http/tests/inspector/network/har/har-page.html is failing on WK2 Release and Debug builds.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html

Was a flaky timeout/failure in previous revisions. 

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -588,8 +588,7 @@
               "path": "/",
               "expires": "",
               "httpOnly": false,
-              "secure": false,
-              "sameSite": "Strict"
+              "secure": false
             }
           ],
           "headers": "<filtered>",
@@ -661,8 +660,7 @@
               "path": "/",
               "expires": "",
               "httpOnly": false,
-              "secure": false,
-              "sameSite": "Strict"
+              "secure": false
             }
           ],
           "headers": "<filtered>",

[Shawn Roberts]

Disregard last comment. I blamed the wrong revision.