| Summary: | [WTF] holdLock should be marked WARN_UNUSED_RETURN | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Robin Morisset
2019-04-15 11:40:33 PDT
Created attachment 367434 [details]
Patch
Attachment 367434 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/Locker.h:123: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WTF/wtf/Locker.h:131: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WTF/wtf/Locker.h:139: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367476 [details]
Patch
Just fix the trivial style nits.
Comment on attachment 367476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367476&action=review r=me > Source/JavaScriptCore/heap/BlockDirectory.cpp:66 > + // FIXME: should we instead do a cheaper thing like a volatile load in the page? Wow, that’s weird. What’s this function used for? (In reply to Keith Miller from comment #4) > Comment on attachment 367476 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367476&action=review > > r=me > > > Source/JavaScriptCore/heap/BlockDirectory.cpp:66 > > + // FIXME: should we instead do a cheaper thing like a volatile load in the page? > > Wow, that’s weird. What’s this function used for? It is used for cancelling the full GC when any part of the heap is paged out. Comment on attachment 367476 [details] Patch Clearing flags on attachment: 367476 Committed r244352: <https://trac.webkit.org/changeset/244352> All reviewed patches have been landed. Closing bug. |