Bug 196916

Summary: [CMake] Remove WEBKIT_WRAP_SOURCELIST
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, jbedard, keith_miller, mark.lam, mcatanzaro, msaboff, pvollan, rniwa, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2019-04-15 10:35:24 PDT
There doesn't appear to be any value for this macro so let's remove it.
Attachments
Patch (9.22 KB, patch)
2019-04-15 10:43 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.57 KB, patch)
2019-04-19 14:54 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.54 KB, patch)
2019-04-19 14:58 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.09 KB, patch)
2020-12-07 11:26 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-15 10:43:15 PDT Comment hidden (obsolete)
Konstantin Tokarev
Comment 2 2019-04-15 14:17:30 PDT
Comment on attachment 367424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367424&action=review > ChangeLog:7 > + Justification is needed here, otherwise anyone looking at git or svn log, or glancing over diff, may wonder why is it a valid change. I think something like thiss will be fine: "WEBKIT_WRAP_SOURCELIST macro is used only to adjust source groups in Visual Studio project without any impact on build process. Its references variable specific to particular target (WebCore) which contradicts our goal of having target-oriented CMake project. It can be reintroduced later in a more clean way, in case anyone needs to have such grouping"
Don Olmstead
Comment 3 2019-04-19 14:54:57 PDT
Created attachment 367834 [details] Patch Adding Changelog
EWS Watchlist
Comment 4 2019-04-19 14:56:37 PDT
Attachment 367834 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 5 2019-04-19 14:58:31 PDT
Created attachment 367837 [details] Patch
Konstantin Tokarev
Comment 6 2019-04-19 17:08:54 PDT
Comment on attachment 367837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367837&action=review > ChangeLog:12 > + CMake project. It can be reintroduced later in a more clean way, in case anyone needs > + to have such grouping. This comment is present only in one changelog file. If you are going to apply it via cq, I have no idea if it will use it for commit message or not (the former is desired)
Don Olmstead
Comment 7 2020-12-07 11:26:38 PST
Created attachment 415567 [details] Patch
EWS
Comment 8 2020-12-07 12:28:15 PST
Committed r270516: <https://trac.webkit.org/changeset/270516> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415567 [details].
Note You need to log in before you can comment on or make changes to this bug.