| Summary: | [CMake] Remove WEBKIT_WRAP_SOURCELIST | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, jbedard, keith_miller, mark.lam, mcatanzaro, msaboff, pvollan, rniwa, ryuan.choi, saam, sergio, tzagallo | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Don Olmstead
2019-04-15 10:35:24 PDT
Created attachment 367424 [details]
Patch
Comment on attachment 367424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367424&action=review > ChangeLog:7 > + Justification is needed here, otherwise anyone looking at git or svn log, or glancing over diff, may wonder why is it a valid change. I think something like thiss will be fine: "WEBKIT_WRAP_SOURCELIST macro is used only to adjust source groups in Visual Studio project without any impact on build process. Its references variable specific to particular target (WebCore) which contradicts our goal of having target-oriented CMake project. It can be reintroduced later in a more clean way, in case anyone needs to have such grouping" Created attachment 367834 [details]
Patch
Adding Changelog
Attachment 367834 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367837 [details]
Patch
Comment on attachment 367837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367837&action=review > ChangeLog:12 > + CMake project. It can be reintroduced later in a more clean way, in case anyone needs > + to have such grouping. This comment is present only in one changelog file. If you are going to apply it via cq, I have no idea if it will use it for commit message or not (the former is desired) Created attachment 415567 [details]
Patch
Committed r270516: <https://trac.webkit.org/changeset/270516> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415567 [details]. |