Bug 196892

Summary: Throw TypeError when custom element constructor returns a wrong element or tries to create itself
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Changes the exception type dino: review+

Description Ryosuke Niwa 2019-04-12 19:56:33 PDT
Throw TypeError when custom element constructor returns a wrong element or tries to create itself
Comment 1 Ryosuke Niwa 2019-04-12 19:58:54 PDT
Created attachment 367374 [details]
Changes the exception type
Comment 2 Dean Jackson 2019-04-15 14:13:12 PDT
Comment on attachment 367374 [details]
Changes the exception type

Is this a new import of the WPT tests? Or will you contribute the change?
Comment 3 Ryosuke Niwa 2019-04-15 14:28:44 PDT
(In reply to Dean Jackson from comment #2)
> Comment on attachment 367374 [details]
> Changes the exception type
> 
> Is this a new import of the WPT tests? Or will you contribute the change?

It's merged in https://github.com/web-platform-tests/wpt/pull/16328 already.
Comment 4 Ryosuke Niwa 2019-04-15 14:45:27 PDT
Comment on attachment 367374 [details]
Changes the exception type

View in context: https://bugs.webkit.org/attachment.cgi?id=367374&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        Update the tests according to https://github.com/whatwg/html/pull/4525.

Oh oops, this should have been pointing to https://github.com/web-platform-tests/wpt/pull/16328 instead.
Comment 5 Ryosuke Niwa 2019-04-15 14:49:08 PDT
Committed r244293: <https://trac.webkit.org/changeset/244293>
Comment 6 Radar WebKit Bug Importer 2019-04-15 14:50:19 PDT
<rdar://problem/49918714>