Bug 196885

Summary: [iOS WK2] Clipped, absolutely positioned elements inside overflow:scroll jiggle
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW ---    
Severity: Normal CC: ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-highsierra-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews104 for mac-highsierra-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
WIP none

Description Simon Fraser (smfr) 2019-04-12 16:52:45 PDT
[iOS WK2] Clipped, absolutely positioned elements inside overflow:scroll jiggle
Comment 1 Simon Fraser (smfr) 2019-04-12 16:55:39 PDT
Created attachment 367358 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-04-12 16:58:08 PDT
<rdar://problem/49869033>
Comment 3 Simon Fraser (smfr) 2019-04-12 17:45:07 PDT
Comment on attachment 367358 [details]
Patch

Patch needs something for "moves" nodes too.
Comment 4 Simon Fraser (smfr) 2019-04-13 10:59:32 PDT
I think we need to compute a ScrollPositioningBehavior for both the ancestor clipping layer and for the primary layer, and teach the scrolling tree nodes about ancestor clipping layers.

I'm not sure this will suffice in all cases (the ancestor clipping can be contributed to by multiple ancestors). We might need to make scrolling tree nodes that represent that clipping ancestor, which currently may not be represented in the graphics layer tree.
Comment 5 Simon Fraser (smfr) 2019-04-13 10:59:46 PDT
I'm concerned that this is getting arbitrarily complex.
Comment 6 Simon Fraser (smfr) 2019-04-16 08:48:07 PDT
Created attachment 367538 [details]
Patch
Comment 7 Simon Fraser (smfr) 2019-04-17 09:46:43 PDT
Created attachment 367636 [details]
Patch
Comment 8 EWS Watchlist 2019-04-17 11:13:38 PDT
Comment on attachment 367636 [details]
Patch

Attachment 367636 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11901912

New failing tests:
scrollingcoordinator/scrolling-tree/positioned-nodes.html
scrollingcoordinator/scrolling-tree/positioned-nodes-complex.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html
Comment 9 EWS Watchlist 2019-04-17 11:13:39 PDT
Created attachment 367653 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 10 EWS Watchlist 2019-04-17 14:45:02 PDT
Comment on attachment 367636 [details]
Patch

Attachment 367636 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11905076

New failing tests:
scrollingcoordinator/scrolling-tree/positioned-nodes.html
scrollingcoordinator/scrolling-tree/positioned-nodes-complex.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html
Comment 11 EWS Watchlist 2019-04-17 14:45:03 PDT
Created attachment 367680 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 12 Simon Fraser (smfr) 2019-05-22 21:18:32 PDT
Created attachment 370483 [details]
Patch
Comment 13 EWS Watchlist 2019-05-22 22:38:27 PDT
Comment on attachment 370483 [details]
Patch

Attachment 370483 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12265898

New failing tests:
scrollingcoordinator/scrolling-tree/positioned-nodes.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html
scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers.html
scrollingcoordinator/scrolling-tree/positioned-nodes-complex.html
scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html
Comment 14 EWS Watchlist 2019-05-22 22:38:29 PDT
Created attachment 370489 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 15 EWS Watchlist 2019-05-22 23:16:53 PDT
Comment on attachment 370483 [details]
Patch

Attachment 370483 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12265945

New failing tests:
scrollingcoordinator/scrolling-tree/positioned-nodes.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html
scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers.html
scrollingcoordinator/scrolling-tree/positioned-nodes-complex.html
scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html
scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html
Comment 16 EWS Watchlist 2019-05-22 23:16:55 PDT
Created attachment 370491 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 17 Simon Fraser (smfr) 2019-05-24 08:27:27 PDT
Created attachment 370571 [details]
WIP