Bug 19679

Summary: iframes with a height of 32,768px or greater do not layout correctly
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Layout and RenderingAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Major Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Testcase
none
Proposed patch hyatt: review+

Timothy Hatcher
Reported 2008-06-19 12:04:10 PDT
If a iframe has a height of 32,768px or greater (INT_MAX + 1), then the iframe does not display in the correct location on the page. This does not happen with other blocks. It seems like an integer overflow problem and could be related to iframes being NSViews on Mac. I am not sure what happens on Windows. Firefox does not have a problem either. See the attached test case. This was found in the Web inspector, since we use iframes to display resource source code. We want to have the frame be the full height of the document, so we set the height to match the size of the frame body. This lets us put other sibling content (http headers) above the frame and have one scrollbar contain the extra content and the frame.
Attachments
Testcase (248 bytes, text/html)
2008-06-19 12:06 PDT, Timothy Hatcher 		no flags
Details
Proposed patch (40.35 KB, patch)
2008-06-19 20:17 PDT, Timothy Hatcher 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2008-06-19 12:06:18 PDT
Created attachment 21845 [details] Testcase
Adam Roben (:aroben)
Comment 2 2008-06-19 12:08:04 PDT
Comment on attachment 21845 [details] Testcase On Windows I see a large block of red, with a large block of green beneath it.
Timothy Hatcher
Comment 3 2008-06-19 12:10:39 PDT
I meant to say SHORT_MAX + 1, not INT_MAX.
Timothy Hatcher
Comment 4 2008-06-19 12:11:08 PDT
So it seems this is a cross platform issue.
Mark Rowe (bdash)
Comment 5 2008-06-19 14:34:13 PDT
<rdar://problem/6022403>
Timothy Hatcher
Comment 6 2008-06-19 20:17:21 PDT
Created attachment 21852 [details] Proposed patch
Dave Hyatt
Comment 7 2008-06-20 11:25:40 PDT
Comment on attachment 21852 [details] Proposed patch r=me
Timothy Hatcher
Comment 8 2008-06-20 15:23:05 PDT
Landed in r34693.
Note You need to log in before you can comment on or make changes to this bug.