Bug 196771

Summary:

Enable Pointer Events on watchOS

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

UI Events

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+

Description Antoine Quint 2019-04-10 09:33:26 PDT

Pointer Events are currently defined as follows:

ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
ENABLE_POINTER_EVENTS_iosmac = ENABLE_POINTER_EVENTS;
ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS;
ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS;
ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS;

This excludes watchOS but there's no good reason why that platform should be excluded.

Comment 1 Antoine Quint 2019-04-10 09:33:38 PDT

<rdar://problem/49040909>

Comment 2 Antoine Quint 2019-04-10 09:35:26 PDT

Created attachment 367129 [details]
Patch

Comment 3 EWS Watchlist 2019-04-10 09:38:34 PDT

Attachment 367129 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Antoine Quint 2019-04-10 09:45:03 PDT

Committed r244114: <https://trac.webkit.org/changeset/244114>