Bug 196765

Summary:

[GStreamer] Adaptive streaming playback broken with GStreamer < 1.12

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Media

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, calvaris, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	calvaris: review+, calvaris: commit-queue-

Description Philippe Normand 2019-04-10 01:33:39 PDT

GStreamer < 1.12 has an incomplete uridownloader implementation so we
can't use WebKitWebSrc for adaptive fragments downloading if this
version is detected.

Comment 1 Philippe Normand 2019-04-10 01:40:24 PDT

Created attachment 367110 [details]
Patch

Comment 2 Xabier Rodríguez Calvar 2019-04-10 02:09:15 PDT

Comment on attachment 367110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367110&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:907
> +    m_origins.add(WTFMove(origin));

Please, collapse these two lines:

m_origins.add(SecurityOrigin::create(response.url()));

Comment 3 Philippe Normand 2019-04-10 02:14:35 PDT

Committed r244109: <https://trac.webkit.org/changeset/244109>

Comment 4 Radar WebKit Bug Importer 2019-04-10 02:15:19 PDT

<rdar://problem/49768460>