Bug 196765

Summary: [GStreamer] Adaptive streaming playback broken with GStreamer < 1.12
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, calvaris, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+, calvaris: commit-queue-

Philippe Normand
Reported 2019-04-10 01:33:39 PDT
GStreamer < 1.12 has an incomplete uridownloader implementation so we can't use WebKitWebSrc for adaptive fragments downloading if this version is detected.
Attachments
Patch (12.62 KB, patch)
2019-04-10 01:40 PDT, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-04-10 01:40:24 PDT
Created attachment 367110 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2019-04-10 02:09:15 PDT
Comment on attachment 367110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367110&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:907 > + m_origins.add(WTFMove(origin)); Please, collapse these two lines: m_origins.add(SecurityOrigin::create(response.url()));
Philippe Normand
Comment 3 2019-04-10 02:14:35 PDT
Committed r244109: <https://trac.webkit.org/changeset/244109>
Radar WebKit Bug Importer
Comment 4 2019-04-10 02:15:19 PDT
<rdar://problem/49768460>
Note You need to log in before you can comment on or make changes to this bug.