Bug 196755 – Add SPI WKNavigationResponse._downloadAttribute

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Add SPI WKNavigationResponse._downloadAttribute

[Alex Christensen]

Created attachment 367090 [details]
Patch

[EWS Watchlist]

Attachment 367090 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:96:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 367090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367090&action=review

> Source/WebKit/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UIProcess/API/APINavigationResponse.h:
> +        * UIProcess/API/Cocoa/WKNavigationResponse.mm:

Please fill out this change log. At least explain what the intent of this change is.

[Alex Christensen]

Created attachment 367148 [details]
Patch

[EWS Watchlist]

Attachment 367148 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:96:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Comment on attachment 367148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367148&action=review

> Source/WebKit/UIProcess/API/APINavigationResponse.h:42
> +    static Ref<NavigationResponse> create(API::FrameInfo& frame, const WebCore::ResourceRequest& request, const WebCore::ResourceResponse& response, bool canShowMIMEType, const WTF::String& downloadAttribute)
>      {
> +        return adoptRef(*new NavigationResponse(frame, request, response, canShowMIMEType, downloadAttribute));
>      }

Can take the opportunity to make the static create() just be a variadic template :)

[Alex Christensen]

Created attachment 367170 [details]
Patch

[EWS Watchlist]

Attachment 367170 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:96:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 367170 [details]
Patch

Clearing flags on attachment: 367170

Committed r244161: <https://trac.webkit.org/changeset/244161>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49794165>