Bug 196752

Summary:

[ews-build] Add unit tests for PrintConfiguration

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196780

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2019-04-09 16:58:14 PDT

We should add unit tests for PrintConfiguration build step in ews-build.

Attachments
Patch (5.34 KB, patch) 2019-04-09 17:02 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-09 17:02:24 PDT

Created attachment 367085 [details] Patch

EWS Watchlist

Comment 2 2019-04-09 17:04:43 PDT Comment hidden (obsolete)

Attachment 367085 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1260: [TestPrintConfiguration.test_success] Undefined variable 'PrintConfiguration' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1298: [TestPrintConfiguration.test_failure] Undefined variable 'PrintConfiguration' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330: [TestPrintConfiguration.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330: [TestPrintConfiguration.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2019-04-09 18:06:47 PDT

Comment on attachment 367085 [details] Patch Clearing flags on attachment: 367085 Committed r244102: <https://trac.webkit.org/changeset/244102>

WebKit Commit Bot

Comment 4 2019-04-09 18:06:48 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-04-09 18:08:48 PDT

<rdar://problem/49758837>

Note You need to log in before you can comment on or make changes to this bug.