Bug 19674 – Default font size should be the same as Safari, I.E. and Firefox: 16 (v.s. the current 14)

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Benjamin Meyer]

Safari, Mac IE, Camino, and Mozilla, etc all have a default size of 16 rather then 14.

Some more info from when Safari 1.0 changed its default to 16
http://weblogs.mozillazine.org/hyatt/archives/2003_04.html#002993

[Tor Arne Vestbø]

Simon, any idea why 14 was chosen? Unless we break something really bad I think we should go for 16 too.

[Antonio Gomes]

tor, just a side note: many layout tests are have currently got their results  updated to expect fontsize default to 13 ... (yes in DRT/QT default it 13 :( )... so we have a double non-conformation here.    // To get DRT compliant to 

see it in DumpRenderTree.cpp

(...)
WebPage::WebPage()
(...)
    //some layout tests lets set the default fontsize to 13.
    settings()->setFontSize(QWebSettings::DefaultFontSize, 13);
(...)

[Antonio Gomes]

ok , english version now:

"... many layout tests had  their expected-results recently updated to expect fontsize default to 13 ..."

sorry about the bugmail spam

(In reply to comment #2)
> tor, just a side note: many layout tests are have currently got their results 
> updated to expect fontsize default to 13 ... (yes in DRT/QT default it 13 :(
> )... so we have a double non-conformation here.    // To get DRT compliant to 
> 
> see it in DumpRenderTree.cpp
> 
> (...)
> WebPage::WebPage()
> (...)
>     //some layout tests lets set the default fontsize to 13.
>     settings()->setFontSize(QWebSettings::DefaultFontSize, 13);
> (...)

[Andras Becsi]

Hi!

I have changed the font sizes in DRT.cpp and qwebsettings.cpp to 16px and ran run-webkit-tests --ignore-mertics.
7 tests failed which previously didn't. Seems that the others have only font metrics problems. Reni and I are going to fully investigate this issue, and send patches to set the default size to 16px and update the metrics in files which need it.

The following tests failed, with render-tree differences:

editing/pasteboard/5761530-1.html:
  DRT places a tab in place of an expected space

editing/pasteboard/5780697-2.html:
  printed size variables differ
  maybe there is a quirksmode issue too 

fast/css/getComputedStyle/computed-style-without-renderer.html:
  border-top-width: 18px should be 1em=16px
  I met this issue once in another test where there was a approx 2px white border on the top but there shouldn't be. Maybe this expected expected a wrong value previously?

fast/css/getComputedStyle/computed-style
  -webkit-perspective-origin: Xpx Ypx twice there is one pixel Y difference

fast/history/history_reload.html:
  DRT fails the test, but QtLaucher does  it right

fast/html/text-field-input-types.html:
  DRT removes a space:
  -A B C D E F
  +A B C DE F

svg/batik/filters/feTile.svg:
  left border flows approx 3px over the edge, only one half of the first numbers can be seen

svg/custom/getscreenctm-in-mixed-content2.xhtml
  This tests the behaviour of SVGLocatable::getScreenCTM() in mixed content:
    Expected matrix [1, 0, 0, 1, 350, 56]
    Got matrix [1, 0, 0, 1, 405, 55]

[Andras Becsi]

Created attachment 39694 [details]
Fix default font sizes in DRT.cpp and qwebsettings.cpp

The patch reconciliates the default font sizes in DRT.cpp and qwebsettings.cpp for regular/fixed fonts from 13px/13px in DRT vs. 14px/14px in qwebsettings to 16px/13px which is the default on other platforms.

This breaks the metrics on ~450 tests, and introduces 8 new failing tests (with --ignore-metrics) which seem to be related to previously hidden bugs:

editing/pasteboard/5761530-1.html
editing/pasteboard/5780697-2.html
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style
fast/history/history_reload.html
fast/html/text-field-input-types.html
svg/batik/filters/feTile.svg
svg/custom/getscreenctm-in-mixed-content2.xhtml

These get into the Skipped list for later investigation.
I'll push all the changes to my qtwebkit clone on gitorious.

[Tor Arne Vestbø]

Perfect, I'll land it once it's on gitorious

[Andras Becsi]

(In reply to comment #6)
> Perfect, I'll land it once it's on gitorious

I've pushed my changes to my gitorious clone:

http://www.gitorious.org/~bbandix/qtwebkit/bbandix-clone

Unforunately the patch has 43718 LOC, which is huge.

[Andras Becsi]

Landed in r48873.