Bug 196737

Summary:

Web Inspector: Debugger: deleting a special breakpoint should disable it

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2019-04-09 10:49:14 PDT

Additionally, if the breakpoint is already disabled, we should beep :)

Attachments
Patch (1.75 KB, patch) 2019-04-13 14:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (1.78 KB, patch) 2019-04-15 11:07 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-04-09 10:49:35 PDT

<rdar://problem/49740680>

Devin Rousso

Comment 2 2019-04-13 14:59:08 PDT

Created attachment 367394 [details] Patch

WebKit Commit Bot

Comment 3 2019-04-15 10:23:42 PDT Comment hidden (obsolete)

Comment on attachment 367394 [details] Patch Rejecting attachment 367394 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 367394, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=367394&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196737&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 367394 from bug 196737. Fetching: https://bugs.webkit.org/attachment.cgi?id=367394 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebInspectorUI/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date W: 0ad446a422dcfe0ef19c372b30c9068e4490ba72 and refs/remotes/origin/master differ, using rebase: :040000 040000 bfd667a4cb95ce3496c8eeda90daf7585e8f4e4e 04de1cb3db7d948c9c29d185cfbaa62afb6af147 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebInspectorUI/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date W: 0ad446a422dcfe0ef19c372b30c9068e4490ba72 and refs/remotes/origin/master differ, using rebase: :040000 040000 bfd667a4cb95ce3496c8eeda90daf7585e8f4e4e 04de1cb3db7d948c9c29d185cfbaa62afb6af147 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 469d0a6c447..95611e18b1c master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 244261 = 469d0a6c447955deb0758a84088fb59b25c68f49 r244262 = c2d0cf11ea65cc78da9e2047f9f299bfca13c6cf r244263 = ae4b638a9ab8561574696048984e05b8d8987467 r244264 = 95611e18b1cdcad1c9b7c35dfaacdcb6dffd5253 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11872083

Devin Rousso

Comment 4 2019-04-15 11:07:37 PDT

Created attachment 367429 [details] Patch

WebKit Commit Bot

Comment 5 2019-04-15 11:34:56 PDT

Comment on attachment 367429 [details] Patch Clearing flags on attachment: 367429 Committed r244274: <https://trac.webkit.org/changeset/244274>

WebKit Commit Bot

Comment 6 2019-04-15 11:34:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.