[WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Takashi Komori]

On WinCairo MiniBrowser, some of pull down menu doesn't work.
We can't disabling JavaScript by clicking Develop menu->Disable JavaScript.

This is because page group and preference are not register properly.

[Takashi Komori]

Created attachment 367033 [details]
Patch

[Fujii Hironori]

Comment on attachment 367033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367033&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113
> +    auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get());

WebKitBrowserWindow is used only for WinCairo at the memoment, but also for AppleWin in the future (hopefully). Should be renamed.
Nit: pageGroup is leaked.
auto pageGroup = adoptWK(...);
And conf, prefs and context are also leaked.

[Takashi Komori]

Created attachment 367099 [details]
Patch

[Takashi Komori]

(In reply to Fujii Hironori from comment #2)
> Comment on attachment 367033 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367033&action=review
> 
> > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113
> > +    auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get());
> WebKitBrowserWindow is used only for WinCairo at the memoment, but also for
> AppleWin in the future (hopefully). Should be renamed.

Changed to "WinMiniBrowser". If more apropriate one exists, I'll change.

> Nit: pageGroup is leaked.
> auto pageGroup = adoptWK(...);
> And conf, prefs and context are also leaked.

Fixed.

[Takashi Komori]

Created attachment 367105 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367105 [details]
Patch

Clearing flags on attachment: 367105

Committed r244106: <https://trac.webkit.org/changeset/244106>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49766482>