Bug 196727

Summary: [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
Product: WebKit Reporter: Takashi Komori <takashi.komori>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, commit-queue, don.olmstead, fujii.hironori, lforschler, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Takashi Komori
Reported 2019-04-09 00:43:55 PDT
On WinCairo MiniBrowser, some of pull down menu doesn't work. We can't disabling JavaScript by clicking Develop menu->Disable JavaScript. This is because page group and preference are not register properly.
Attachments
Patch (1.48 KB, patch)
2019-04-09 00:49 PDT, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2019-04-09 21:48 PDT, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Patch (2.31 KB, patch)
2019-04-09 22:58 PDT, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Takashi Komori
Comment 1 2019-04-09 00:49:27 PDT
Created attachment 367033 [details] Patch
Fujii Hironori
Comment 2 2019-04-09 02:23:44 PDT
Comment on attachment 367033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367033&action=review > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113 > + auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get()); WebKitBrowserWindow is used only for WinCairo at the memoment, but also for AppleWin in the future (hopefully). Should be renamed. Nit: pageGroup is leaked. auto pageGroup = adoptWK(...); And conf, prefs and context are also leaked.
Takashi Komori
Comment 3 2019-04-09 21:48:06 PDT
Created attachment 367099 [details] Patch
Takashi Komori
Comment 4 2019-04-09 21:52:16 PDT
(In reply to Fujii Hironori from comment #2) > Comment on attachment 367033 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367033&action=review > > > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113 > > + auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get()); > WebKitBrowserWindow is used only for WinCairo at the memoment, but also for > AppleWin in the future (hopefully). Should be renamed. Changed to "WinMiniBrowser". If more apropriate one exists, I'll change. > Nit: pageGroup is leaked. > auto pageGroup = adoptWK(...); > And conf, prefs and context are also leaked. Fixed.
Takashi Komori
Comment 5 2019-04-09 22:58:08 PDT
Created attachment 367105 [details] Patch
WebKit Commit Bot
Comment 6 2019-04-10 01:00:46 PDT
Comment on attachment 367105 [details] Patch Clearing flags on attachment: 367105 Committed r244106: <https://trac.webkit.org/changeset/244106>
WebKit Commit Bot
Comment 7 2019-04-10 01:00:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-04-10 01:01:26 PDT
<rdar://problem/49766482>
Note You need to log in before you can comment on or make changes to this bug.