| Summary: | [CMake] Apple builds should use ICU_INCLUDE_DIRS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, annulen, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 367006 [details]
Patch
Created attachment 367007 [details]
Patch
Comment on attachment 367007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367007&action=review > ChangeLog:8 > + Set ICU_INCLUDE_DIRS for Apple platforms. Please add description from your Bugzilla comment, it's more informative Created attachment 367041 [details]
Patch
Adding more descriptive changelog.
The commit-queue encountered the following flaky tests while processing attachment 367041 [details]: imported/w3c/web-platform-tests/xhr/event-upload-progress.htm bug 196736 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 367041 [details]: media/W3C/video/events/event_progress.html bug 196637 (author: pilgrim@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 367041 [details] Patch Clearing flags on attachment: 367041 Committed r244081: <https://trac.webkit.org/changeset/244081> All reviewed patches have been landed. Closing bug. |
The Apple platform is using ${DERIVED_SOURCES_WTF_DIR} for hosting the ICU headers. Instead it should stage the headers into ${ICU_INCLUDE_DIRS} so no special handling is needed.