Bug 196699

Summary: -f[no-]var-tracking-assignments is GCC-only
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-04-08 11:06:46 PDT
-f[no-]var-tracking-assignments is GCC-only
Attachments
Patch (1.37 KB, patch)
2019-04-08 11:07 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.54 KB, patch)
2019-04-08 13:17 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-04-08 11:07:07 PDT
Created attachment 366954 [details] Patch
Ross Kirsling
Comment 2 2019-04-08 11:10:57 PDT
This was introduced in bug 185462 and causes JSCOnly to fail on Mac. (Interestingly, "unknown argument" is just a warning for clang-cl, but it's an error for clang proper.)
Michael Catanzaro
Comment 3 2019-04-08 12:58:40 PDT
I guess you can just remove it because it's broken, bug #186273. The warning seems to be gone in GCC 9 anyway.
Michael Catanzaro
Comment 4 2019-04-08 12:58:59 PDT
Please close that bug if you take this approach.
Ross Kirsling
Comment 5 2019-04-08 13:09:27 PDT
Oh sure, happy to remove it instead if we no longer need it.
Ross Kirsling
Comment 6 2019-04-08 13:17:51 PDT
Created attachment 366973 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-04-08 13:57:44 PDT
Comment on attachment 366973 [details] Patch for landing Clearing flags on attachment: 366973 Committed r244044: <https://trac.webkit.org/changeset/244044>
WebKit Commit Bot
Comment 8 2019-04-08 13:57:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-04-08 13:59:27 PDT
<rdar://problem/49710076>
Note You need to log in before you can comment on or make changes to this bug.