Bug 196699

Summary: -f[no-]var-tracking-assignments is GCC-only
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Ross Kirsling 2019-04-08 11:06:46 PDT
-f[no-]var-tracking-assignments is GCC-only
Comment 1 Ross Kirsling 2019-04-08 11:07:07 PDT
Created attachment 366954 [details]
Patch
Comment 2 Ross Kirsling 2019-04-08 11:10:57 PDT
This was introduced in bug 185462 and causes JSCOnly to fail on Mac.

(Interestingly, "unknown argument" is just a warning for clang-cl, but it's an error for clang proper.)
Comment 3 Michael Catanzaro 2019-04-08 12:58:40 PDT
I guess you can just remove it because it's broken, bug #186273.

The warning seems to be gone in GCC 9 anyway.
Comment 4 Michael Catanzaro 2019-04-08 12:58:59 PDT
Please close that bug if you take this approach.
Comment 5 Ross Kirsling 2019-04-08 13:09:27 PDT
Oh sure, happy to remove it instead if we no longer need it.
Comment 6 Ross Kirsling 2019-04-08 13:17:51 PDT
Created attachment 366973 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-04-08 13:57:44 PDT
Comment on attachment 366973 [details]
Patch for landing

Clearing flags on attachment: 366973

Committed r244044: <https://trac.webkit.org/changeset/244044>
Comment 8 WebKit Commit Bot 2019-04-08 13:57:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-04-08 13:59:27 PDT
<rdar://problem/49710076>