Bug 196695

Summary: [iOS] WebContent processes should be marked as "Foreground Running" when their view is visible
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, jer.noble, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2019-04-08 10:02:01 PDT 
WebContent processes should be marked as "Foreground Running" when their view is visible.
Comment 1 Chris Dumez 2019-04-08 10:02:12 PDT 
<rdar://problem/48073787>
Comment 2 Chris Dumez 2019-04-08 10:25:55 PDT 
Created attachment 366949 [details]
Patch
Comment 3 Tim Horton 2019-04-08 10:30:46 PDT 
Comment on attachment 366949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366949&action=review

> Source/WTF/wtf/FeatureDefines.h:182
> +#define ENABLE_VISIBILITY_PROPAGATION_VIEW

Isn’t this a platform-feature-existence thing, not a WebKit feature toggle? So, HAVE, not ENABLE.
Comment 4 Simon Fraser (smfr) 2019-04-08 10:52:03 PDT 
Comment on attachment 366949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366949&action=review

> Source/WebKit/UIProcess/PageClient.h:286
> +    virtual void didCreateContextForVisibilityPropagation(uint32_t contextID) { }

I think we should typedef the uint32_t in our code, and refer to it as a "LayerHostingContextID" everywhere. Otherwise, "contextID" is just too vague, and too easily confused with other types of context.
Comment 5 Chris Dumez 2019-04-08 14:06:37 PDT 
Created attachment 366977 [details]
Patch
Comment 6 Tim Horton 2019-04-08 14:32:17 PDT 
Comment on attachment 366977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366977&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:258
> +- (void)_cleanupVisibilityPropagationView

"cleanup"? what kind of cleaning! looks like "remove" to me :D
Comment 7 Chris Dumez 2019-04-08 14:34:25 PDT 
Created attachment 366982 [details]
Patch
Comment 8 Chris Dumez 2019-04-09 10:21:35 PDT 
Created attachment 367051 [details]
Patch
Comment 9 WebKit Commit Bot 2019-04-09 11:08:33 PDT 
Comment on attachment 367051 [details]
Patch

Clearing flags on attachment: 367051

Committed r244085: <https://trac.webkit.org/changeset/244085>
Comment 10 WebKit Commit Bot 2019-04-09 11:08:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Chris Dumez 2019-04-09 14:42:49 PDT 
Follow-up in <https://trac.webkit.org/changeset/244095> to fix webkitpy test failure.