Bug 196695 – [iOS] WebContent processes should be marked as "Foreground Running" when their view is visible

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

WebContent processes should be marked as "Foreground Running" when their view is visible.

[Chris Dumez]

<rdar://problem/48073787>

[Chris Dumez]

Created attachment 366949 [details]
Patch

[Tim Horton]

Comment on attachment 366949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366949&action=review

> Source/WTF/wtf/FeatureDefines.h:182
> +#define ENABLE_VISIBILITY_PROPAGATION_VIEW

Isn’t this a platform-feature-existence thing, not a WebKit feature toggle? So, HAVE, not ENABLE.

[Simon Fraser (smfr)]

Comment on attachment 366949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366949&action=review

> Source/WebKit/UIProcess/PageClient.h:286
> +    virtual void didCreateContextForVisibilityPropagation(uint32_t contextID) { }

I think we should typedef the uint32_t in our code, and refer to it as a "LayerHostingContextID" everywhere. Otherwise, "contextID" is just too vague, and too easily confused with other types of context.

[Chris Dumez]

Created attachment 366977 [details]
Patch

[Tim Horton]

Comment on attachment 366977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366977&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:258
> +- (void)_cleanupVisibilityPropagationView

"cleanup"? what kind of cleaning! looks like "remove" to me :D

[Chris Dumez]

Created attachment 366982 [details]
Patch

[Chris Dumez]

Created attachment 367051 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367051 [details]
Patch

Clearing flags on attachment: 367051

Committed r244085: <https://trac.webkit.org/changeset/244085>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Follow-up in <https://trac.webkit.org/changeset/244095> to fix webkitpy test failure.