Bug 196690

Summary:

[JSCOnly] Add an 32bit JSCOnly EWS that runs tests

Product:

WebKit

Reporter:

Pablo Saavedra <psaavedra>

Component:

Tools / Tests

Assignee:

Pablo Saavedra <psaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dbates, ews-watchlist, glenn, lforschler, mcatanzaro, pvollan, webkit-bug-importer, xan.lopez

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none

Description Pablo Saavedra 2019-04-08 07:45:16 PDT

We are trying to bring the X86 port in JSC up to speed. We are now at a point where it would make sense to have a EWS bot to track regressions, since some of them will apply to all 32bit ports. 

If this is set up in a Linux x86-64 machine all you need to do is build JSC with build-jsc --32-bit (recently made to work).

Comment 1 Pablo Saavedra 2019-04-08 07:47:28 PDT

Created attachment 366935 [details]
patch

Comment 2 Pablo Saavedra 2019-04-08 07:50:32 PDT

We are already aware about the new EWS CI (https://bugs.webkit.org/show_bug.cgi?id=196641) but , in meantime, we wish go ahead with this new EWS. The idea is to  move all the EWS workers at the same time in the future.

Comment 3 Michael Catanzaro 2019-04-08 08:57:15 PDT

Comment on attachment 366935 [details]
patch

What architecture is this? x86?

Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more clear?

Comment 4 Pablo Saavedra 2019-04-08 09:38:36 PDT

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 366935 [details]
> patch
> 
> What architecture is this? x86?
> 
> Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more
> clear?

Yes. it is i386. Since it other EWS for x86_64 has not a reference to the PC architecture in the name I assumed as a right notation just add the 32 bit and make no references to the architecture. In others words no architecture reference = PC.


I have no objections to rename the worker with other nomenclature  whatever you'd prefer better.

Comment 5 Alexey Proskuryakov 2019-04-08 09:41:28 PDT

Having i386 in the name would be consistent with jsc-armv7-ews.

Comment 6 Pablo Saavedra 2019-04-09 00:34:02 PDT

(In reply to Alexey Proskuryakov from comment #5)
> Having i386 in the name would be consistent with jsc-armv7-ews.

Yes, this makes sense.

Comment 7 Pablo Saavedra 2019-04-09 00:40:34 PDT

Created attachment 367032 [details]
patch

Comment 8 Pablo Saavedra 2019-04-09 00:41:09 PDT

(In reply to Pablo Saavedra from comment #6)
> (In reply to Alexey Proskuryakov from comment #5)
> > Having i386 in the name would be consistent with jsc-armv7-ews.
> 
> Yes, this makes sense.

New patch uploaded with the required changes

Comment 9 WebKit Commit Bot 2019-04-09 08:43:06 PDT

Comment on attachment 367032 [details]
patch

Clearing flags on attachment: 367032

Committed r244076: <https://trac.webkit.org/changeset/244076>

Comment 10 WebKit Commit Bot 2019-04-09 08:43:07 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 Radar WebKit Bug Importer 2019-04-09 08:44:24 PDT

<rdar://problem/49736225>