Bug 196690

Summary: [JSCOnly] Add an 32bit JSCOnly EWS that runs tests
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: Tools / TestsAssignee: Pablo Saavedra <psaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, ews-watchlist, glenn, lforschler, mcatanzaro, pvollan, webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Pablo Saavedra
Reported 2019-04-08 07:45:16 PDT
We are trying to bring the X86 port in JSC up to speed. We are now at a point where it would make sense to have a EWS bot to track regressions, since some of them will apply to all 32bit ports. If this is set up in a Linux x86-64 machine all you need to do is build JSC with build-jsc --32-bit (recently made to work).
Attachments
patch (2.41 KB, patch)
2019-04-08 07:47 PDT, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (2.44 KB, patch)
2019-04-09 00:40 PDT, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pablo Saavedra
Comment 1 2019-04-08 07:47:28 PDT
Created attachment 366935 [details] patch
Pablo Saavedra
Comment 2 2019-04-08 07:50:32 PDT
We are already aware about the new EWS CI (https://bugs.webkit.org/show_bug.cgi?id=196641) but , in meantime, we wish go ahead with this new EWS. The idea is to move all the EWS workers at the same time in the future.
Michael Catanzaro
Comment 3 2019-04-08 08:57:15 PDT
Comment on attachment 366935 [details] patch What architecture is this? x86? Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more clear?
Pablo Saavedra
Comment 4 2019-04-08 09:38:36 PDT
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 366935 [details] > patch > > What architecture is this? x86? > > Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more > clear? Yes. it is i386. Since it other EWS for x86_64 has not a reference to the PC architecture in the name I assumed as a right notation just add the 32 bit and make no references to the architecture. In others words no architecture reference = PC. I have no objections to rename the worker with other nomenclature whatever you'd prefer better.
Alexey Proskuryakov
Comment 5 2019-04-08 09:41:28 PDT
Having i386 in the name would be consistent with jsc-armv7-ews.
Pablo Saavedra
Comment 6 2019-04-09 00:34:02 PDT
(In reply to Alexey Proskuryakov from comment #5) > Having i386 in the name would be consistent with jsc-armv7-ews. Yes, this makes sense.
Pablo Saavedra
Comment 7 2019-04-09 00:40:34 PDT
Created attachment 367032 [details] patch
Pablo Saavedra
Comment 8 2019-04-09 00:41:09 PDT
(In reply to Pablo Saavedra from comment #6) > (In reply to Alexey Proskuryakov from comment #5) > > Having i386 in the name would be consistent with jsc-armv7-ews. > > Yes, this makes sense. New patch uploaded with the required changes
WebKit Commit Bot
Comment 9 2019-04-09 08:43:06 PDT
Comment on attachment 367032 [details] patch Clearing flags on attachment: 367032 Committed r244076: <https://trac.webkit.org/changeset/244076>
WebKit Commit Bot
Comment 10 2019-04-09 08:43:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-04-09 08:44:24 PDT
<rdar://problem/49736225>
Note You need to log in before you can comment on or make changes to this bug.